8000 t0 extractions for new Hadrons module by fjosw · Pull Request #171 · fjosw/pyerrors · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

t0 extractions for new Hadrons module #171

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 25, 2023
Merged

t0 extractions for new Hadrons module #171

merged 2 commits into from
Apr 25, 2023

Conversation

fjosw
Copy link
Owner
@fjosw fjosw commented Apr 21, 2023

I refactored the fit to extract t0 into fit_t0 and added a new function that can extract t0 from a file generated by the new Hadrons module FlowObservables (see aportelli/Hadrons#108).

@fjosw fjosw requested a review from s-kuberski April 21, 2023 15:43
@s-kuberski
Copy link
Collaborator

Hi. Looks good! I always thought about refactoring the openQCD routine by calling another routine that does the I/O and extracts the Yang-Mills action density Y. This routine could then also be used by a user of the package. However, the user would probably extract Y at flow time t_0, such that one would have a somewhat circular dependence.
If you consider this useful also for your purposes (Y is a good observable to look at autocorrelation), you could add this feature for the hadrons and openQCD routines. Otherwise, I am totally fine with your current changes.

@jkuhl-uni
Copy link
Collaborator

Hi. Looks good! I always thought about refactoring the openQCD routine by calling another routine that does the I/O and extracts the Yang-Mills action density Y. This routine could then also be used by a user of the package. However, the user would probably extract Y at flow time t_0, such that one would have a somewhat circular dependence. If you consider this useful also for your purposes (Y is a good observable to look at autocorrelation), you could add this feature for the hadrons and openQCD routines. Otherwise, I am totally fine with your current changes.

Hi, first of all @fjosw thank you for the changes. That is a good idea.
Concerning @s-kuberski's comment: When I had a look at the openQCD module last time, I already thought about something similar, but more general... couldn't we make a general purpose functio for reading openQCD formats, from which we can then query the value of interest from a list sorted by the configuration number?
Maybe we should discuss this in s different issue, but do you think somthing along those lines is possible?

@jkuhl-uni
Copy link
Collaborator

I just realised this is pretty much present with read_flow_obs(), I think I just wondered if read_rwms() could simply call this too

@s-kuberski
Copy link
Collaborator

Hi. I don't really get what you like to have. The information for the reweighting factors has nothing to do with the information in the gradient flow data file, so I don't see why one would couple the two. (On top of this, there are three different formats for the reweighting factor files that needed to be implemented in order to read the files properly. - In contrast to the gradient flow files)

@fjosw
Copy link
Owner Author
fjosw commented Apr 25, 2023

Thanks for the feedback @s-kuberski and @jkuhl-uni. In this PR I only intended to add the t0 extraction to the hadrons module. I don't have any plans to restructure the openQCD module for now but feel free to work on it!

@fjosw fjosw merged commit 1184a0f into develop Apr 25, 2023
@fjosw fjosw deleted the feat/hadrons_flow_observables branch June 12, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-kuberski s-kuberski Awaiting requested review from s-kuberski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fjosw @s-kuberski @jkuhl-uni
0