Modern supply chain management #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this is less relevant when using the public nuget.org feed for all dependencies, it establishes an appropriate baseline any modern repo should start with. If we ever have a need for private feeds, they can be added here to ensure that intended-private packages always load from the intended private feed rather than from potentially maliicous same-named packages on the public feed.
Although this is less relevant when few projects reference the same packages, it establishes an appropriate baseline any modern repo should start with.
According to documentation, GlobalPackageReference silently takes care of the former explicit PrivateAssets and IncludeAssets values. From https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management#global-package-references we have: > A global package reference is used to specify that a package will be used by every project in a repository. This includes packages that do versioning, extend your build, or any other packages that are needed by all projects. Global package references are added to the PackageReference item group with the following metadata: > > - IncludeAssets="Runtime;Build;Native;contentFiles;Analyzers" > This ensures that the package is only used as a development dependency and prevents any compile-time assembly references. > - PrivateAssets="All" > This prevents global package references from being picked up by downstream dependencies. Note that this technically *begins* the versioning of Fixie.Tests, but that is good as before this change it was getting the misleading default of 1.0.0.0, and now at least it versions accurately with the system under test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This establishes modern supply chain controls and uses them to simplify the solution:
Verified version numbers still appear on assemblies and nuget packages.