Add target framework net7.0 #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndencies as implied by the corresponding csproj file. We need to do this manually as long as we have a nuspec, and we need a nuspec due to undesirable behavior of `dotnet pack` in the presence of the abnormal Microsoft.NET.Test.Sdk package.
…eir test method as the apparent start of execution, take into account potential MethodBase.Invoke optimization implementation details introduced in net7.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds target framework
net7.0where appropriate:net7.0to theFixie,Fixie.TestAdapter, andFixie.Testsprojects.Fixie.TestAdaptercsproj changes in the corresponding nuspec.Fixie.Consoleproject targeting our support window lower bound ofnetcoreapp3.1. As adotnet ...tool definition, we target low and already compensate for that withRollForwardbehavior.net7.0.The primary novel change accounted for here on
net7.0runs comes in the method that cleans up a test failure stack trace for presentation. Here, we aim to present a stack trace where execution apparently begins in the test method itself, omitting surrounding test runner and method invocation noise leading up to the invocation of the test method. The implementation tends to need attention with each .NET release, and this time the change in .NET behavior comes in its new optimizations withinMethodBase.Invokeas described here: https://devblogs.microsoft.com/dotnet/performance_improvements_in_net_7/#reflection . In short, we can seek and omit a few additional stack trace lines which represent the new reflection emit logic.