Upgrade MinVer in preparation for including target framework net6.0 #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `TargetFrameworks` within Fixie.TestAdapter: Unlike typical projects, Fixie.TestAdapter is packaged with the combination of `dotnet pack` and a manual `*.nuspec` file. Although that is generally supported, the moment we pluralize to `TargetFrameworks` MinVer fails to pick up on the intended version and we end up with the incorrect package `Fixie.TestAdapter.1.0.0.nupkg`.
…g MinVer: Changes to `IncludeAssets` come from following the https://www.nuget.org/packages/MinVer/ installation guidance exactly.
…ie.TestAdapter` version number correctly during a `dotnet pack` with `--no-build` specified.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While experimenting with mult-targeting the Fixie.TestAdapter project, a bug in our old MinVer reference appeared which prevented that package from getting an appropriate version number. Thankfully a simple upgrade of MinVer addresses the issue. Additionally, the newer version of MinVer no longer requires an additional workaround in our build script, so we can simplify all
dotnet packlines to be alike.Steps Taken:
Reveal a bug in version numbering by pluralizing
TargetFrameworktoTargetFrameworkswithin Fixie.TestAdapter:Unlike typical projects, Fixie.TestAdapter is packaged with the combination of
dotnet packand a manual*.nuspecfile. Although that is generally supported, the moment we pluralize toTargetFrameworksMinVer fails to pick up on the intended version and we end up with the incorrect packageFixie.TestAdapter.1.0.0.nupkg.Fix the ability to version the Fixie.TestAdapter package, by upgrading MinVer:
Changes to
IncludeAssetscome from following the https://www.nuget.org/packages/MinVer/ installation guidance exactly.Simplify build script now that MinVer can successfully infer the
Fixie.TestAdapterversion number correctly during adotnet packwith--no-buildspecified.