8000 Update issue templates by fivetran-elijahdavis · Pull Request #133 · fivetran/fivetran_connector_sdk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update issue templates #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

fivetran-elijahdavis
Copy link
Collaborator

No description provided.

< 8000 div class="TimelineItem js-comment-container" data-gid="IC_kwDOLIPssM6pvqOK" data-url="/fivetran/fivetran_connector_sdk/comments/IC_kwDOLIPssM6pvqOK/partials/timeline_issue_comment" >
Copy link
height bot commented May 2, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Collaborator
@alsnkline alsnkline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alsnkline
Copy link
Collaborator

@varundhall this is updating the templates for issues (which we are opening)
I think it is safe to merge without your README check.

Copy link
Collaborator
@varundhall varundhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-elijahdavis
Copy link
Collaborator Author
fivetran-elijahdavis commented May 6, 2025

@fivetran-elijahdavis these changes don't follow the standard GitHub YAML structure. Please refer https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository

-@varundhall Updated and new format attached
Screenshot 2025-05-06 at 9 38 06 AM
Screenshot 2025-05-06 at 9 38 13 AM

@fivetran-elijahdavis
Copy link
Collaborator Author

@alsnkline @fivetran-sadiemartin - Should we add something about Save Me Time?

"Need help getting your first connection up and running quickly?

Our team of Professional Services experts is available to provide free advisory services to help you build your first Connector SDK connection. This includes guidance on setup, troubleshooting, and best practices. To get started, simply file a support ticket."

attributes:
label: Contact Details
description: How can we get in touch with you if we need more info?
placeholder: ex. email@example.com
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a sensitive detail; people don't feel comfortable sharing the emails publicly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed

id: version
attributes:
label: Connector SDK version
description: What version of Connector SDK are you using? You can check the version with 'pip show fivetran-connector-sdk' or install the latest version with 'pip install --upgrade fivetran-connector-sdk.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while asking for version we are also telling to upgrade to the latest, which can provide incorrect response. Let's just stick to pip show

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

id: terms
attributes:
label: Code of Conduct
description: By submitting this issue, you agree to follow our [Code of Conduct](https://example.com).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example.com? Please update or review the AI generated stuff 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an example to start the dialogue with product. So...do we want a code of conduct or not?

@fivetran-sadiemartin / @alsnkline - do we want to include a code of conduct or no?

label: Code of Conduct
description: By submitting this issue, you agree to follow our [Code of Conduct](https://example.com).
options:
- label: I agree to follow this project's Code of Conduct
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even have such code of conduct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an example to start the dialogue with product. So...do we want a code of conduct or not?

@fivetran-sadiemartin / @alsnkline - do we want to include a code of conduct or no?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name: Request
description: Suggest an idea for a Connector SDK project.
title: "[Request]: "
labels: ["Project", "New Feature"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check with Product, which labels they want and how

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fivetran-sadiemartin / @alsnkline - what labels would you like shown in the forms?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we discuss this in our meeting?
how about:
"bug"
"enhancement"
"documentation"
"question"
"duplicate". "invalid", "wontfix"

ChatGPT had a bunch of other suggestions that we likely don't need at first.

attributes:
label: Contact Details
description: How can we get in touch with you if we need more info?
placeholder: ex. email@example.com
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

id: version
attributes:
label: Connector SDK version
description: What version of Connector SDK are you using? You can check the version with 'pip show fivetran-connector-sdk' or install the latest version with 'pip install --upgrade fivetran-connector-sdk.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Comment on lines 49 to 53
label: Code of Conduct
description: By submitting this issue, you agree to follow our [Code of Conduct](https://example.com).
options:
- label: I agree to follow this project's Code of Conduct
required: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@alsnkline
Copy link
Collaborator

Re save me time here
I don't think it would make sense - it would drop the conversion for issues for sure.

We currently point back to the docs in a section about support - and have a purple call out at the top of that page. I think that's good enough.

@fivetran-elijahdavis
Copy link
Collaborator Author

@varundhall / @alsnkline - all changes have been added to the templates. The last item is what contact information we put in the code of conduct. Do we use one from CSG or mine?

  • Code of conduct added
  • Code of conduct link added to both templates.

@alsnkline
Copy link
Collaborator
alsnkline commented May 15, 2025

developers@fivetran.com is one we could consider using - or elijah.davis@fivetran.com for starters.

I'll ask amanda about using developers.

@alsnkline
Copy link
Collaborator

I checked with Amanda she suggested using sdk@fivetran.com which she monitors and is currently only used for new partners submitting requests to the Partner SDK program.

I think that's a perfect address to use for this.

add contact info for enforcement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0