Auto import: Honor JSON_CONFIGURATION_DIR #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JC5
reviewed
Mar 27, 2025
JC5
reviewed
Mar 27, 2025
|
Looks good, thanks! I added two comments, no big things. |
Make it More extensible and only verify once
<
8000
batch-deferred-content class="d-inline-block" data-url="/firefly-iii/data-importer/commits/checks-statuses-rollups">
JC5
approved these changes
Mar 28, 2025
|
Nice, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue # (if relevant).
Fixes: firefly-iii/firefly-iii#10026
Changes in this pull request:
Lightly Tested.
I would like to extend this to the single import command & and the post endpoint, but that would be a breaking change as now they expect a
$jsonFile, ?string $importableFile), and it would need to be$jsonOrImportableFile, ?string $JsonFile)@JC5