8000 [firebase_admob] Support v2 embedding by bparrishMines · Pull Request #1365 · firebase/flutterfire · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[firebase_admob] Support v2 embedding #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Dec 11, 2019
Merged

[firebase_admob] Support v2 embedding #1365

merged 22 commits into from
Dec 11, 2019

Conversation

bparrishMines
Copy link
Contributor

Description

flutter/flutter#41866

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@bparrishMines bparrishMines requested a review from amirh as a code owner November 4, 2019 23:40
@amirh amirh mentioned this pull request Nov 5, 2019
Closed
xster
xster approved these changes Nov 16, 2019
View reviewed changes
Copy link
Contributor
@xster xster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % tests

packages/firebase_admob/android/src/main/AndroidManifest.xml
@@ -1,9 +1,4 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="io.flutter.plugins.firebaseadmob">

<!-- Sample AdMob App ID: ca-app-pub-3940256099942544~3347511713 -->
<meta-data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I removed this because the user should be adding this to their app AndroidManifest.xml and not to the plugin code. It didn't cause any problems with compilation or tests when I removed it.

packages/firebase_admob/test/firebase_admob_e2e.dart Outdated
E2EWidgetsFlutterBinding.ensureInitialized();

testWidgets('Initialize Firebase Admob', (WidgetTester tester) async {
// expect(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were you going to add something here?

@bparrishMines bparrishMines merged commit 68eb9fa into firebase:master Dec 11, 2019
@bparrishMines bparrishMines deleted the admob_embedding branch December 11, 2019 23:27
@letiagoalves
Copy link

hi @xster, is this already published in pub.dev?

The plugin is not working since I updated my app to support v2 embedding and I am using the final version

@letiagoalves
Copy link

I see that it was only introduced in 0.9.1, but that version is not published. When will it be published?

@bparrishMines
Copy link
Contributor Author

I see that it was only introduced in 0.9.1, but that version is not published. When will it be published?

@letiagoalves @xster It's now published to the latest version. I believe we were waiting on finalization of the v2 embedding API and I forgot to publish when it was settled.

@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xster xster xster approved these changes

@amirh amirh Awaiting requested review from amirh

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bparrishMines @letiagoalves @xster @googlebot
0