TunConfig is not updated when client IP changes in init
#8451
Labels
Comments
github-merge-queue bot
pushed a commit
that referenced
this issue
Mar 16, 2025
Currently, we are only emitting updates to the `TunConfig` when the routes or the DNS servers change. This isn't correct, we should also emit updates for it when the IPs or the search-domain changes. In order to achieve that, we create a new `TunConfig` based on the existing one every time we receive an `InterfaceConfig` update. Depending on our current state, we may create an entirely new `TunConfig` or create a new one where we copy the fields in from the new `InterfaceConfig`. We then unconditionally call `maybe_update_tun_config` which does the necessary work to only emit updates when things actually changed. To ensure this works in all cases and the latest update is always reflected on the TUN device, we also extend the proptests to assert the latest search domain. Fixes: #8451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not a major problem since the chance of this happening is low, but I noticed we never apply this change when it comes in from the portal in
initbecause of the complex logic we have around state updates and tun config.The text was updated successfully, but these errors were encountered: