8000 Ban zcoin nodes with version < 0.13.8.8 by justanwar · Pull Request #797 · firoorg/firo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ban zcoin nodes with version < 0.13.8.8 #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2019
Merged

Ban zcoin nodes with version < 0.13.8.8 #797

merged 2 commits into from
Dec 23, 2019

Conversation

justanwar
Copy link
Member

PR intention

Ban versions of Zcoin client 0.13.8.5 and below

Code changes brief

"Parse standard client version string in form of /Satosh:0.x.y.z/ and drop connection with every legacy node" - As per #742

@justanwar justanwar mentioned this pull request Dec 17, 2019
Closed
psolstice
psolstice requested changes Dec 17, 2019
View reviewed changes
src/version.h Outdated
@@ -49,6 +49,6 @@ static const int SHORT_IDS_BLOCKS_VERSION = 90013;
static const int INVALID_CB_NO_BAN_VERSION = 90013;

//! minimum version of official client to connect to
static const int MIN_ZCOIN_CLIENT_VERSION = 130802; // 0.13.8.2
static const int MIN_ZCOIN_CLIENT_VERSION = 130805; // 0.13.8.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to set it to the first version that use sigma padding (including private releases!).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to locate which private version sigma padding was released in, if that fails it looks like we have to go with v0.13.8.8

@riordant riordant added this to the 13.8.10 milestone Dec 17, 2019
@justanwar justanwar changed the title Ban zcoin nodes with version ≤ 0.13.8.5 Ban zcoin nodes with version < 0.13.8.8 Dec 23, 2019
@reubenyap reubenyap merged commit 0c85825 into master Dec 23, 2019
@reubenyap reubenyap deleted the ban-130805 branch December 23, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riordant riordant riordant approved these changes

@psolstice psolstice psolstice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justanwar @riordant @psolstice @reubenyap
0