Using absolute path for dumpwallet rpc #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-bezrukov
previously approved these changes
Jun 28, 2021
a-bezrukov
previously approved these changes
Jul 8, 2021
122aca5 to
5a886ad
Compare
a-bezrukov
approved these changes
Jul 8, 2021
psolstice
requested changes
Jul 9, 2021
| @@ -693,8 +693,12 @@ UniValue dumpwallet(const JSONRPCRequest& request) | |||
|
|
|||
| EnsureWalletIsUnlocked(pwallet); | |||
|
|
|||
| boost::filesystem::path filePath = request.params[0].get_str(); | |||
| filePath = boost::filesystem::absolute(filePath); | |||
There was a problem hiding this comment.
I suggest using canonical instead of absolute if you really want to show users where their file ends up. E.g. /home/user/mydir/../somedir/wallet.dump isn't something user can quickly parse
psolstice
approved these changes
Jul 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes dumpwallet path issues, when on some platforms dump is not saved at correct directory.
It also returns the path as an output.