10000 Fix a minor compilation issue with clang 17. by cassandras-lies · Pull Request #1616 · firoorg/firo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix a minor compilation issue with clang 17. #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix a minor compilation issue with clang 17. #1616

wants to merge 1 commit into from
+10 −2

Conversation

cassandras-lies
Copy link
Contributor

PR intention

Fix compilation with clang 17.

Code changes brief

This complies with minor pedantry around static variable initialisation introduced in clang 17.

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 18, 2025 •
edited
Loading

Walkthrough

The static constant members fractional_mask and integer_mask of the Fixed template class were moved from inline initialization within the class definition to out-of-class template specializations. This adjustment separates their declarations and definitions, maintaining the same logic and values, and addresses linkage concerns for template static members.

Changes

File(s) Change Summary
src/fixed.h Moved static constant member initializations for fractional_mask and integer_mask outside the class template, leaving only declarations inside the class and providing explicit out-of-class definitions. No logic or control flow changes.

Poem

A hop and a leap, the masks jump outside,
No more inline secrets for templates to hide.
Declarations within, definitions now roam,
Ensuring each mask finds a proper home.
With linkage now tidy, the code hops along—
A rabbit’s small fix keeps everything strong! 🐇

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 18, 2025
View reviewed changes
Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/fixed.h (1)

438-445: Provide out-of-class definitions for the masks
Solid: you’ve added the explicit template definitions for both masks to resolve linkage errors. As an optional C++17 improvement, consider marking them inline to avoid multiple-definition clashes across translation units:

-template <std::size_t I, std::size_t F>
-const typename Fixed<I, F>::base_type Fixed<I, F>::fractional_mask =
+template <std::size_t I, std::size_t F>
+inline const typename Fixed<I, F>::base_type Fixed<I, F>::fractional_mask =
     ~((~typename Fixed<I, F>::base_type()) << Fixed<I, F>::fractional_bits);

-template <std::size_t I, std::size_t F>
-const typename Fixed<I, F>::base_type Fixed<I, F>::integer_mask =
+template <std::size_t I, std::size_t F>
+inline const typename Fixed<I, F>::base_type Fixed<I, F>::integer_mask =
     ~Fixed<I, F>::fractional_mask;
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a95ceb and 36f1703.

📒 Files selected for processing (1)
  • src/fixed.h (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Build for macOS (CMake)
  • GitHub Check: Create Source Distribution
  • GitHub Check: Build for Windows (CMake)
  • GitHub Check: Build for Linux (CMake)
🔇 Additional comments (1)
src/fixed.h (1)

253-254: Separate static constant declarations
The in-class initializations for fractional_mask and integer_mask have been correctly replaced by bare declarations to satisfy clang 17’s stricter static member rules.

@aleflm
Copy link
Contributor
aleflm commented May 19, 2025 •
edited
Loading

I have this fixed in: 17faa3f

Which is part of this PR: #1618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cassandras-lies @aleflm
0