8000 update contrib libSM version by aleflm · Pull Request #1590 · firoorg/firo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update contrib libSM version #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

update contrib libSM version #1590

wants to merge 1 commit into from

Conversation

aleflm
Copy link
Contributor
@aleflm aleflm commented May 15, 2025

PR intention

Update libSM package

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented May 15, 2025 •
edited
Loading

Walkthrough

The version of the libSM package was updated from 1.2.2 to 1.2.6 in the build configuration. This included changing the archive file extension from .tar.bz2 to .tar.xz and updating the corresponding SHA256 hash to match the new archive.

Changes

File(s) Change Summary
depends/packages/libSM.mk Updated libSM version from 1.2.2 to 1.2.6, changed archive extension to .tar.xz, and updated SHA256.

Poem

A hop and a skip, the version jumps high,
libSM’s new feathers let old code fly.
From bzip to xz, the archive’s now neat,
Hashes refreshed for a verified treat.
With every small change, the project feels new—
🐇 Cheers to the update, from rabbit to you!

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efe9940 and e18edda.

📒 Files selected for processing (1)
  • depends/packages/libSM.mk (1 hunks)
🔇 Additional comments (3)
depends/packages/libSM.mk (3)

2-2: Bump libSM to 1.2.6
The version has been updated to the latest stable release.

4-4: Update archive extension to .tar.xz
Changing from .tar.bz2 to .tar.xz aligns with the upstream packaging for version 1.2.6.

5-5:

❓ Verification inconclusive

Verify the new SHA256 hash
Ensure the integrity of the downloaded archive by checking its SHA256 matches the updated value.

🏁 Script executed:

#!/bin/bash
# Verify SHA256 of libSM-1.2.6.tar.xz
url="http://xorg.freedesktop.org/releases/individual/lib/libSM-1.2.6.tar.xz"
curl -sL "$url" -o libSM-1.2.6.tar.xz
echo "be7c0abdb15cbfd29ac62573c1c82e877f9d4047ad15321e7ea97d1e43d835be  libSM-1.2.6.tar.xz" | sha256sum -c -

Length of output: 391

To work around the missing sha256sum, let’s compute the hash via Python:

🏁 Script executed:

#!/bin/bash
python3 - << 'EOF'
import urllib.request, hashlib, sys

url = "http://xorg.freedesktop.org/releases/individual/lib/libSM-1.2.6.tar.xz"
data = urllib.request.urlopen(url).read()
digest = hashlib.sha256(data).hexdigest()
print(f"Computed SHA256: {digest}")
sys.exit(0 if digest == "be7c0abdb15cbfd29ac62573c1c82e877f9d4047ad15321e7ea97d1e43d835be" else 1)
EOF

Length of output: 3320

Let’s fetch the archive without SSL checks and compute the SHA256 via OpenSSL:

🏁 Script executed:

#!/bin/bash
url="http://xorg.freedesktop.org/releases/individual/lib/libSM-1.2.6.tar.xz"
# Download without certificate verification
wget --no-check-certificate -qO libSM-1.2.6.tar.xz "$url"
# Compute and print SHA256
openssl dgst -sha256 libSM-1.2.6.tar.xz

Length of output: 435

Verify libSM-1.2.6 SHA256
Ensure the integrity of the downloaded archive by manually checking its SHA256 against the value in depends/packages/libSM.mk (line 5):

$(package)_sha256_hash=be7c0abdb15cbfd29ac62573c1c82e877f9d4047ad15321e7ea97d1e43d835be

Suggested manual verification:

curl -LO http://xorg.freedesktop.org/releases/individual/lib/libSM-1.2.6.tar.xz
sha256sum libSM-1.2.6.tar.xz

Confirm the output matches be7c0abdb15cbfd29ac62573c1c82e877f9d4047ad15321e7ea97d1e43d835be.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aleflm aleflm mentioned this pull request May 15, 2025
Closed
@aleflm aleflm closed this May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aleflm
0