fix sparktest segfault #1575
Merged
fix sparktest segfault #1575
+37
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes introduce new methods and functions to improve thread management and shutdown procedures across wallet and Spark-related components. The Changes
Sequence Diagram(s)sequenceDiagram
participant TestTeardown as SparkTestingSetup::~SparkTestingSetup
participant Wallet as pwalletMain->sparkWallet
participant ThreadPool as ParallelOpThreadPool
TestTeardown->>Wallet: FinishTasks()
Wallet->>ThreadPool: Shutdown()
ThreadPool->>ThreadPool: Shutdown and join all threads
sequenceDiagram
participant SparkState as CSparkState::Reset()
participant WalletGlobal as ShutdownWallet()
participant Wallet as pwalletMain
participant SparkWallet as sparkWallet
participant ThreadPool as ParallelOpThreadPool
SparkState->>WalletGlobal: ShutdownWallet()
WalletGlobal->>Wallet: (if exists)
Wallet->>SparkWallet: FinishTasks()
SparkWallet->>ThreadPool: Shutdown()
ThreadPool->>ThreadPool: Shutdown and join all threads
WalletGlobal->>Wallet: Clear address books and key values
SparkState->>SparkState: Clear Spark state data
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (8)
🚧 Files skipped from review as they are similar to previous changes (8)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
0484b09 to
3ca4daa
Compare
3ca4daa to
b185d94
Compare
psolstice
approved these changes
May 3, 2025
levonpetrosyan93
approved these changes
May 3, 2025
aleflm
added a commit
to aleflm/firo
that referenced
this pull request
May 6, 2025
aleflm
added a commit
to aleflm/firo
that referenced
this pull request
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Su
2BC7
ggestion cannot be applied right now. Please check back later.
PR intention
Fixing spark test random fails:
https://github.com/firoorg/firo/actions/runs/14621407026/job/41022138619#step:9:265
https://github.com/aleflm/firo/actions/runs/14784900125/job/41511473433#step:9:265
https://github.com/aleflm/firo/actions/runs/14783545040/job/41507522710#step:9:211
CSparkWallethas its own thread pool. The problem isCSparkWallet::threadPool, which has type ofParallelOpThreadPoolmight still be active with active tasks, while we are removingpmainwallethere:firo/src/test/test_bitcoin.cpp
Line 141 in 7f56324