Added code for rabbitmq connector #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: therahulbhati <rjbhati009@gmail.com>
vishal-biyani
requested changes
Aug 4, 2020
Signed-off-by: therahulbhati <rjbhati009@gmail.com>
Signed-off-by: therahulbhati <rjbhati009@gmail.com>
Signed-off-by: therahulbhati <rjbhati009@gmail.com>
Signed-off-by: therahulbhati <rjbhati009@gmail.com>
Signed-off-by: therahulbhati <rjbhati009@gmail.com>
Signed-off-by: therahulbhati <rjbhati009@gmail.com>
Signed-off-by: therahulbhati <rjbhati009@gmail.com>
| - `SOURCE_NAME`: Optional. Name of the Source. Default is "KEDAConnector" | ||
| - `MAX_RETRIES`: Maximum number of times an http endpoint will be retried upon failure. | ||
| - `CONTENT_TYPE`: Content type used while creating post request | ||
| - `HOST`: AMQP URI connection string, like `amqp://guest:password@localhost:5672/vhost` |
There was a problem hiding this comment.
For now, we can let this be - but in a separate PR, can we have a way to attach sensitive things like password through a secret & volume instead of ENV variable?
|
A very minor doc comment looks good otherwise. |
Signed-off-by: therahulbhati <rjbhati009@gmail.com>
Signed-off-by: therahulbhati <rjbhati009@gmail.com>
Signed-off-by: therahulbhati <rjbhati009@gmail.com>
Signed-off-by: therahulbhati <rjbhati009@gmail.com>
vishal-biyani
approved these changes
Aug 11, 2020
22 tasks
Sign up for free
to join thi
5DFD
s conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: therahulbhati rjbhati009@gmail.com