8000 Rename Jellyfish references in the code by mickel8 · Pull Request #196 · fishjam-dev/fishjam · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rename Jellyfish references in the code #196

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 16, 2024
Merged

Rename Jellyfish references in the code #196

merged 3 commits into from
May 16, 2024

Conversation

mickel8
Copy link
Contributor
@mickel8 mickel8 commented May 16, 2024 •
edited
Loading

Acknowledging the stipulations set forth:

  • I hereby confirm that a Pull Request involving updates to the Software Development Kit (SDK) has been smoothly merged, currently awaits processing, or is otherwise deemed unnecessary in this context.
  • I also affirm that another Pull Request, specifically addressing updates to the documentation body (commonly referred to as 'docs'), has either been successfully incorporated, is in the process of review, or is considered superfluous under the prevailing circumstances.

@mickel8 mickel8 force-pushed the rebranding branch 3 times, most recently from a8565fe to 632c386 Compare May 16, 2024 13:06
@codecov Codecov
Copy link
codecov bot commented May 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.20879% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 86.91%. Comparing base (d3fb68f) to head (890170f).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   86.98%   86.91%   -0.07%     
==========================================
  Files          74       74              
  Lines        1521     1529       +8     
==========================================
+ Hits         1323     1329       +6     
- Misses        198      200       +2
Files Coverage Δ
lib/jellyfish.ex 100.00% <100.00%> (ø)
lib/jellyfish/component.ex 75.00% <ø> (ø)
lib/jellyfish/component/file.ex 100.00% <100.00%> (ø)
lib/jellyfish/component/hls.ex 96.77% <100.00%> (ø)
lib/jellyfish/component/hls/ets_helper.ex 100.00% <ø> (ø)
lib/jellyfish/component/hls/httpoison.ex 0.00% <ø> (ø)
lib/jellyfish/component/hls/ll_storage.ex 76.31% <ø> (ø)
lib/jellyfish/component/hls/manager.ex 97.05% <ø> (ø)
lib/jellyfish/component/hls/recording.ex 89.47% <ø> (ø)
lib/jellyfish/component/hls/request_handler.ex 91.89% <100.00%> (ø)
... and 63 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3fb68f...890170f. Read the comment docs.

@mickel8 mickel8 force-pushed the rebranding branch 3 times, most recently from 62f79a8 to e8f9bfe Compare May 16, 2024 13:50
@mickel8 mickel8 requested a review from roznawsk May 16, 2024 13:51
roznawsk
roznawsk reviewed May 16, 2024
View reviewed changes
test/jellyfish_web/integration/server_notification_test.exs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 331 Jellyuser -> FishjamUser

docs/authentication_architecture.md
@@ -4,7 +4,7 @@

- **CL** - client
- **BE** - business logic (backend) implemented by the user
- **JF** - Jellyfish
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FJ

lib/jellyfish/application.ex Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 87 JF -> FJ

test/jellyfish/config_reader_test.exs Outdated
@@ -156,12 +156,12 @@ defmodule Jellyfish.ConfigReaderTest do
assert ConfigReader.read_components_used() == []

System.put_env("JF_COMPONENTS_USED", "hls")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FJ

@roznawsk roznawsk self-requested a review May 16, 2024 15:05
@mickel8 mickel8 merged commit 7316dd0 into main May 16, 2024
7 checks passed
@mickel8 mickel8 deleted the rebranding branch May 16, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roznawsk roznawsk roznawsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickel8 @roznawsk
0