8000 change(ci): Fixing All Workflows by damienjburks · Pull Request #771 · finos/common-cloud-controls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

change(ci): Fixing All Workflows #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/format_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,16 @@ jobs:
prettier-fmt-check:
runs-on: ubuntu-latest
steps:
- title: Checkout repository
- name: Checkout repository
uses: actions/checkout@v3

- title: Set up Node.js
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: "16"

- title: Install Prettier
- name: Install Prettier
run: npm install --save-dev prettier

- title: Check formatting with Prettier
- name: Check formatting with Prettier
run: npx prettier --check "**/*.md" --config ./.config/.prettierrc
2 changes: 1 addition & 1 deletion .github/workflows/links.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
steps:
- uses: actions/checkout@v4

- title: Link Checker
- name: Link Checker
id: lychee
uses: lycheeverse/lychee-action@v1
with:
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/linting_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,37 +8,37 @@ jobs:
runs-on: ubuntu-latest

steps:
- title: Checkout repository
- name: Checkout repository
uses: actions/checkout@v3

- title: Set up Node.js
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: "16"

- title: Install markdownlint-cli
- name: Install markdownlint-cli
run: npm install -g markdownlint-cli

- title: Run markdownlint
- name: Run markdownlint
run: markdownlint '**/*.md' --config ./.config/.markdownlint.yaml

yaml-lint:
runs-on: ubuntu-latest

steps:
- title: Checkout repository
- name: Checkout repository
uses: actions/checkout@v3

- title: Set up Python
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: "3.x" # Use any compatible Python 3 version

- title: Install yamllint
- name: Install yamllint
run: |
python -m pip install --upgrade pip
pip install yamllint

- title: Run yamllint
- name: Run yamllint
run: |
yamllint -c ./.config/.yamllint .
16 changes: 8 additions & 8 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@ jobs:
- uses: actions/checkout@v4
name: Build

- title: Configure Go
- name: Configure Go
uses: actions/setup-go@v5

- title: Install dependencies
- name: Install dependencies
run: go mod download

- title: Get Build Target
- name: Get Build Target
id: process_target
run: |
# Read the input for a single build target
Expand All @@ -36,7 +36,7 @@ jobs:
echo "Build target: $build_target"
echo "target=$build_target" >> $GITHUB_OUTPUT

- title: Create Release Artifacts
- name: Create Release Artifacts
run: |
# Create all artifacts for the specified build target
build_target="${{ steps.process_target.outputs.target }}"
Expand All @@ -59,7 +59,7 @@ jobs:
fi
done

- title: Upload Artifacts
- name: Upload Artifacts
uses: actions/upload-artifact@v4.4.0
with:
name: ccc-catalogs
Expand All @@ -71,13 +71,13 @@ jobs:
needs: build
runs-on: ubuntu-latest
steps:
- title: Download Artifacts
- name: Download Artifacts
uses: actions/download-artifact@v4.1.8
with:
name: ccc-catalogs

# Create a GitHub release
- title: Create GitHub Release
- name: Create GitHub Release
id: create_release
uses: actions/create-release@v1
with:
Expand All @@ -90,7 +90,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# Upload the artifacts to the release
- title: Upload Release Assets
- name: Upload Release Assets
run: |
for file in ./*
do
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sonatype_scan.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- title: Sonatype Lifecycle SCA Scan
- name: Sonatype Lifecycle SCA Scan
id: evaluate
uses: sonatype/actions/evaluate@v1
with:
Expand All @@ -31,7 +31,7 @@ jobs:
scan-targets: ${{ env.SonatypeScanTarget }}
module-exclude: ${{ env.ExcludeDirectory }}

- title: Save Sonatype SBOM
- name: Save Sonatype SBOM
uses: sonatype/actions/fetch-sbom@v1
if: always() && steps.evaluate.outputs.scan-id
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/todo_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
runs-on: ubuntu-latest

steps:
- title: Checkout code
- name: Checkout code
uses: actions/checkout@v4

- title: Check for TODOs in services directory
- name: Check for TODOs in services directory
uses: damienjburks/simple-todo-checker@1.0.0
with:
path: "./services"
4 changes: 2 additions & 2 deletions .github/workflows/yaml_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
runs-on: ubuntu-latest

steps:
- title: Checkout repository
- name: Checkout repository
uses: actions/checkout@v3

- title: Validate YAML Schema
- name: Validate YAML Schema
uses: InoUno/yaml-ls-check@develop
with:
schemaMapping: |
Expand Down
8 changes: 4 additions & 4 deletions schemas/controls-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"items": {
"type": "object",
"properties": {
"name": {
"title": {
"type": "string",
"description": "Name of the control family (e.g., 'Data')"
},
Expand All @@ -55,7 +55,7 @@
"type": "string",
"description": "Multi-line objective of the control"
},
"requirements": {
"assessment-requirements": {
"type": "array",
"items": {
"type": "object",
Expand Down Expand Up @@ -124,12 +124,12 @@
}
}
},
"required": ["id", "title", "objective", "requirements", "threat-mappings", "guideline-mappings"],
"required": ["id", "title", "objective", "assessment-requirements", "threat-mappings", "guideline-mappings"],
"additionalProperties": false
}
}
},
"required": ["name", "description"],
"required": ["title", "description"],
"additionalProperties": false
}
}
Expand Down
4 changes: 2 additions & 2 deletions schemas/threats-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
"additionalProperties": false
}
},
"mappings": {
"external-mappings": {
"type": "array",
"items": {
"type": "object",
Expand All @@ -88,7 +88,7 @@
}
}
},
"required": ["id", "title", "description", "capabilities", "mappings"],
"required": ["id", "title", "description", "capabilities", "external-mappings"],
"additionalProperties": false
}
}
Expand Down
133 changes: 66 additions & 67 deletions services/crypto/key/metadata.yaml
Original file line number Diff line number Diff line change
@@ -1,73 +1,72 @@
metadata:
id: CCC.KeyMgmt
title: Key Management
description: |
Key Management Service is a tool provided by cloud service providers
to securely create, store, and manage cryptographic keys used to
encrypt and decrypt sensitive data.
version: "2025.06"
last-modified: "2025-06-05T11:20:00-05:00"
applicability-categories: []
mapping-references: []
id: CCC.KeyMgmt
title: Key Management
de 46CA scription: |
Key Management Service is a tool provided by cloud service providers
to securely create, store, and manage cryptographic keys used to
encrypt and decrypt sensitive data.
version: "2025.06"
last-modified: "2025-06-05T11:20:00-05:00"
applicability-categories: []
mapping-references: []

release_details:
- version: "2025.06"
assurance_level: None
threat_model_url: None
threat_model_author: None
red_team: None
red_team_exercise_url: None
release_manager:
name: Damien Burks
github_id: damienjburks
company: Citi
summary: |
This initial release is part of the first batch of control catalogs
produced by the CCC. It is the result of thousands of hours dedicated to
exploring different ways of working and collaborating, on top of time
spent researching, writing, and reviewing the content. This marks a huge
milestone for the CCC and the broader community as further releases will
continue to build on this foundation. A huge thanks to everyone who has
brought us to this point!
change_log:
- version: "2025.06"
assurance_level: None
threat_model_url: None
threat_model_author: None
red_team: None
red_team_exercise_url: None
release_manager:
name: Damien Burks
github_id: damienjburks
company: Citi
summary: |
This initial release is part of the first batch of control catalogs
produced by the CCC. It is the result of thousands of hours dedicated to
exploring different ways of working and collaborating, on top of time
spent researching, writing, and reviewing the content. This marks a huge
milestone for the CCC and the broader community as further releases will
continue to build on this foundation. A huge thanks to everyone who has
brought us to this point!
change_log:
- |
This initial release contains a variety of commits designed to capture
all of the capabilities, threats, and controls for this service category.
contributors:
- name: Eddie Knight
github_id: eddie-knight
company: Sonatype
- name: Damien Burks
github_id: damienjburks
company: Citi
- name: Maxime Coquerel
github_id: zigmax
company: RBC
- name: Sonali Mendis
github_id: smendis-scottlogic
company: Scott Logic
- name: Michael Lysaght
github_id: mlysaght2017
company: Citi
- name: Joel Matthews
github_id: jmatthews-scottlogic
company: Scott Logic
- name: Diego Mastroianni
github_id: dmastroianni
company: Moody's
- name: sshiells-scottlogic
github_id: sshiells-scottlogic
company: Scott Logic
- name: Vladimir Rabotka
github_id: vrabotka
company: Morgan Stanley
- name: Kris West
github_id: kriswest
company: NatWest Group
- name: Rob Moffat
github_id: robmoffat
company: FINOS
- name: abikhuil
github_id: abikhuil
company: LSEG

contributors:
- name: Eddie Knight
github_id: eddie-knight
company: Sonatype
- name: Damien Burks
github_id: damienjburks
company: Citi
- name: Maxime Coquerel
github_id: zigmax
company: RBC
- name: Sonali Mendis
github_id: smendis-scottlogic
company: Scott Logic
- name: Michael Lysaght
github_id: mlysaght2017
company: Citi
- name: Joel Matthews
github_id: jmatthews-scottlogic
company: Scott Logic
- name: Diego Mastroianni
github_id: dmastroianni
company: Moody's
- name: sshiells-scottlogic
github_id: sshiells-scottlogic
company: Scott Logic
- name: Vladimir Rabotka
github_id: vrabotka
company: Morgan Stanley
- name: Kris West
github_id: kriswest
company: NatWest Group
- name: Rob Moffat
github_id: robmoffat
company: FINOS
- name: abikhuil
github_id: abikhuil
company: LSEG
Loading
0