8000 Simplify Result.Tuple, Remove unused Data.Double, should be Data.Float by deusaquilus · Pull Request #375 · finos/morphir-scala · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Simplify Result.Tuple, Remove unused Data.Double, should be Data.Float #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2023
Merged

Simplify Result.Tuple, Remove unused Data.Double, should be Data.Float #375

merged 1 commit into from
Sep 1, 2023

Conversation

deusaquilus
Copy link
Contributor
@deusaquilus deusaquilus commented Sep 1, 2023 •
edited
Loading
  • Result.Tuple can use a list of Result[TA, VA], doesn't actually need a tuple type.
  • Introducing Data.Float(float) was incorrect. Data.Double(double) was also incorrect. It should have been Data.Float(double) since a morphir float is a Java double. Fixed that up.

@netlify
Copy link
netlify bot commented Sep 1, 2023 •
edited
Loading

✅ Deploy Preview for magical-donut-e8221d ready!

Name Link
🔨 Latest commit ae02e2b
🔍 Latest deploy log https://app.netlify.com/sites/magical-donut-e8221d/deploys/64f15282d724710008168219
😎 Deploy Preview https://deploy-preview-375--magical-donut-e8221d.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

DamianReeves
DamianReeves approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member
@DamianReeves DamianReeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DamianReeves DamianReeves merged commit d15d171 into finos:main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamianReeves DamianReeves DamianReeves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deusaquilus @DamianReeves
0