Simplify Evaluator calls in Native Functions #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for magical-donut-e8221d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9deeed4 to
41f4394
Compare
4646af8 to
0e0c291
Compare
0e0c291 to
1bda951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storeobject in the Native SDK objects does not conceptually make sense, pass around the evaluator instead.GlobalDefsand pass those around. This significantly simplifies many evaluator functions includinghandleApplyResultwhich Native often uses. This involved breaking things aren't actually the call-stack (i.e. global definitions) from Store. They don't make sense in there anyway.handleApplyResult2which helps calling native functions that have lambdas with multiple arguments e.g.Dict.filter(which haskandvarguments).