Contramap, IR and Source printing improvements #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for magical-donut-e8221d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -0,0 +1,8 @@ | |||
| package org.finos.morphir.datamodel | |||
|
|
|||
| sealed trait UnionType | |||
There was a problem hiding this comment.
What is the difference between SealedTrait, Enum, and Sum?
There was a problem hiding this comment.
When I used reflection to construct them I needed to be able to tell Scala 3 Enum and SealedTrait apart. Now since I use Mirror.ordinal it's not needed. I'll keep in mind to remove one of the cases.
Sign up for free
<
5FD5
strong>to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contramapand various other deriver and MDM helper functions.Deriver.scalabecause the latter is differently defined for Scala 2 and Scala 3.Migration Guide:
org.finos.morphir.datamodel.SpecificDeriverwithorg.finos.morphir.datamodel.CustomDeriver.org.finos.morphir.datamodel.{given}should still work in Scala 3 (since implicits are automatically imported via the given-import mechanic. It will also now work to callorg.finos.morphir.datamodel._.