Add remaining Decimal SDK functions #631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Is this file intended to be here?
There was a problem hiding this comment.
It is not. Removed
michelchan
reviewed
Jun 24, 2024
| @@ -24,10 +33,16 @@ object DecimalSDK { | |||
| RTDecimal(result) | |||
| } | |||
|
|
|||
| val asString = DynamicNativeFunction1("toString") { | |||
There was a problem hiding this comment.
the val name should be consistent
There was a problem hiding this comment.
toString is already defined for all objects in scala. I can do _toString or the likes if we want the name to look the same, but I can't override it, since the return value is different than the existing defined toString
There was a problem hiding this comment.
I forgot about that 😆 let's do _toString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the remaining unimplemented functions that are defined in the Morphir spec for Decimal.
The is also a small amount of refactoring, moving a small number of Decimal functions from Native to the DecimalSDK. This is done to ensure all functionality for Decimal is in the same location.