Enable Linting of Elm files #565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardpeters
reviewed
Apr 2, 2024
There was a problem hiding this comment.
This file should probably just be deleted, or if not, it should be unmodified. I frequently need to test stuff out in Ellie, but the default code loaded is inconvenient for "Evaluate some random definition" - this was a template to quickly copy stuff in, or to let other people do so.
I probably certainly never should have added it in the first place.
edwardpeters
reviewed
Apr 2, 2024
|
|
||
| passingCollectionTests : Test | ||
| passingCollectionTests = | ||
| Test.concat <| |
There was a problem hiding this comment.
Why is it necessary to specify Test.concat here, but other Test. functions are just named directly?
There was a problem hiding this comment.
You had mentioned to me in Slack that you were intending to use Test.concat here... this needs to be Test.concat or be wrapped in a describe.
… of number params
…inouts explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.