fix for dealiasing extractor #555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix (and added additional testing) for a bug relating to type dealiasing
A prior PR addressed an issue where opaque types were being rejected on entry points due to the use of
lookupTypeSpecificationrather thanlookupTypeDefinition. This fix was not applied to the extractor utility functions which are used by the type checker. Because these are only used in deeper type checking (which is currently only called by tests), it was not immediately caught.This PR applies that fix to the extractor utility. Additionally, it expands the distributions the type checker covers to include some which use opaque types (so that this or similar bugs will be caught in the future).