Comparable #506
Comparable #506
Conversation
|
|
||
| val nativeCtors: Map[FQName, SDKConstructor] = Map( | ||
| FQName.fromString("Morphir.SDK:Maybe:just") -> just, | ||
| FQName.fromString("Morphir.SDK:Maybe:nothing") -> nothing, | ||
| FQName.fromString("Morphir.SDK:Result:ok") -> ok, | ||
| FQName.fromString("Morphir.SDK:Result:err") -> err | ||
| FQName.fromString("Morphir.SDK:Result:err") -> err, | ||
| FQName.fromString("Morphir.SDK:Basics:GT") -> gt, |
There was a problem hiding this comment.
Just FYI, I added support to be able to put these in the "new" sdk/*SDK.scala definitions, if you prefer to have them there. I think it's straightforward, but happy to walk through if no.
There was a problem hiding this comment.
Thanks, switched mine over to follow that pattern
morphir/runtime/src/org/finos/morphir/runtime/quick/EvaluatorQuick.scala
Outdated
Show resolved
Hide resolved
morphir/runtime/test/jvm/src/org/finos/morphir/runtime/EvaluatorMDMTests.scala
Show resolved
Hide resolved
morphir/src/org/finos/morphir/ir/conversion/ToMorphirType.scala
Outdated
Show resolved
Hide resolved
morphir/src/org/finos/morphir/ir/conversion/ToMorphirValue.scala
Outdated
Show resolved
Hide resolved
5c704e1 to
c0a934c
Compare
|
@DamianReeves I'm happy with this, please review when you're able. |
53f398f to
6da0e32
Compare
|
|
||
| case (Concept.Order, RTValue.ConstructorResult(FQString("Morphir.SDK:Basics:gT"), List())) => | ||
| Data.Order(1) | ||
| case (Concept.Order, RTValue.ConstructorResult(FQString("Morphir.SDK:Basics:lT"), List())) => |
| Data.Order(1) | ||
| case (Concept.Order, RTValue.ConstructorResult(FQString("Morphir.SDK:Basics:lT"), List())) => | ||
| Data.Order(-1) | ||
| case (Concept.Order, RTValue.ConstructorResult(FQString("Morphir.SDK:Basics:eQ"), List())) => |
There was a problem hiding this comment.
This is using a FQString, which is an extractor intended for easy matching, given that FQName(someString) doesn't work in match statements. FQString uses toString (and then falls back to matching on that string); given that the default is camelCase for the localName, EQ becomes eQ.
Potentially that extractor could be broken up for different formats, but that seemed like a lot of additional complexity for minor gain.
There was a problem hiding this comment.
Well that FQString extractor is wrong and not following Morphir name handling conventions. That is going to add un-needed confusion.
There was a problem hiding this comment.
I only feel comfortable merging this PR if there is a fast follower to correct FQString. The Morphir naming conventions are unique enough, adding an arbitrary divergence will only complicate things now and in the future.
There was a problem hiding this comment.
I think it's correct when used for functions, but not for constructors/types - looking over use cases, tho, it is mostly (only?) being used for constructors/types. That will only take a moment to change.
There was a problem hiding this comment.
I fixed it, fast enough follow? :)
Implemented Comparable and basics SDK functions that use it