Typechecker needs to do additional deliasing #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Typechecker was not dealising aliases that exist in the middle of a curried function
- Typechecker was not dealising leaf types
- Both of these issues were causing issues in client code
✅ Deploy Preview for magical-donut-e8221d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| val newBindings = typeParams.toList.zip(typeArgs.toList).toMap | ||
| val missedName = helper( | ||
| fqn.packagePath != name.packagePath || fqn.modulePath != name.modulePath, | ||
| new OtherTypeError(s"Constructor $fqn does not match type name $name") |
There was a problem hiding this comment.
If you want to have a friendlier name you can do ${name.toCamelCase} ($name) ... or better yet let this be driven bu an EvaluationContext setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.