Add InvalidArguments to OpenError, ChannelError and ResolveError enums #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Error and ResolveError enums
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Fixed broken unit tests
Fixed broken unit test
|
Thanks for taking this on @KhurramJalil. Rather than updating BridgingTypes.ts and BrowserTypes.ts directly, the schema files that they are generated from need to be updated. You can find the relevant section of the schema file at: https://github.com/KhurramJalil/FDC3/blob/f63785ae6615d44ff64fa986d1640573945937da/packages/fdc3-schema/schemas/api/api.schema.json#L302-L362 Once updated, run the following to generate the source files: cd packages/fdc3-schema
npm install
npm run buildYou should then have some modified files in your checkout that you can then commit to your PR branch. |
|
Oh and also the docs page at: https://github.com/KhurramJalil/FDC3/blob/patch-2/website/docs/api/ref/Errors.md |
hughtroeger
approved these changes
Apr 22, 2025
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
Fixed #1490 by adding InvalidArguments inside OpenError, ChannelError and ResolveError enums
Related Issue
Resolves #1490
#1490
Contributor License Agreement
Review Checklist
DesktopAgent,Channel,PrivateChannel,Listener,Bridging)?JSDoc comments on interfaces and types should be matched to the main documentation in /docs
Conformance test definitions should cover all required aspects of an FDC3 Desktop Agent implementation, which are usually marked with a MUST keyword, and optional features (SHOULD or MAY) where the format of those features is defined
The Web Connection protocol and Desktop Agent Communication Protocol schemas must be able to support all necessary aspects of the Desktop Agent API, while Bridging must support those aspects necessary for Desktop Agents to communicate with each other
npm run build) run and the results checked in?Generated code will be found at
/src/api/BrowserTypes.tsand/or/src/bridging/BridgingTypes.tsBaseContextschema applied viaallOf(as it is in existing types)?titleanddescriptionprovided for all properties defined in the schema?npm run build) run and the results checked in?Generated code will be found at
/src/context/ContextTypes.ts