8000 fix(drand): add null HistoricalBeaconClient for old beacons by simlecode · Pull Request #6459 · filecoin-project/venus · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(drand): add null HistoricalBeaconClient for old beacons #6459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2025
Merged

fix(drand): add null HistoricalBeaconClient for old beacons #6459

merged 2 commits into from
Mar 20, 2025

Conversation

simlecode
Copy link
Collaborator

关联的Issues (Related Issues)

filecoin-project/lotus#12830

改动 (Proposed Changes)

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前，需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 存在兼容性问题（接口, 配置，数据，灰度），如果存在需要进行文档说明 / This PR has compatibility issues (API, Configuration, Data, GrayRelease), if so, need to be documented.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link
codecov-commenter commented Mar 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 22%. Comparing base (b8c8317) to head (399ae6d).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #6459   +/-   ##
======================================
- Coverage      22%     22%   -1%     
======================================
  Files         758     758           
  Lines       96354   96357    +3     
======================================
- Hits        22089   22079   -10     
- Misses      71397   71407   +10     
- Partials     2868    2871    +3
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tediou5
tediou5 approved these changes Mar 20, 2025
View reviewed changes
Copy link
Collaborator
@tediou5 tediou5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me, thank you

@tediou5 tediou5 merged commit f45e264 into master Mar 20, 2025
3 checks passed
@tediou5 tediou5 deleted the feat/historical-beacon-client branch March 20, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tediou5 tediou5 tediou5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simlecode @codecov-commenter @tediou5
0