10000 Decouples Mouse Crosshair Speed [Aiming] from Mouse Speed [Camera] by AL2009man · Pull Request #620 · fgsfdsfgs/perfect_dark · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Decouples Mouse Crosshair Speed [Aiming] from Mouse Speed [Camera] #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: port
Choose a base branch
from

Conversation

AL2009man
Copy link
@AL2009man AL2009man commented May 29, 2025

In the past, Mouse's Crosshair Speed is treated as a Multiplier, however, it's not communicated to the end-user, ultimately believing the user may want to increase the mouse sensitivity to...10.00 while keeping the Crosshair Sens around 3.00. The user found out that it increased the Crosshair Speed as a result

This addresses #595, which the Crosshair Speed becomes independent of the general Mouse Camera system, allowing Joanna Dark to mix-and-match sensitivity styles.

As this PR will once again override user's muscle memory, this will require playtesting from KB/M users on how the overall Crosshair Scaling feels. the end goal is getting a sweet spot between regular mouse camera and crosshair camera within a default slider of 2.50, this will be tricky to nail. this'd be a Draft PR for the time being.

edit: this also includes a unified Camera Sensitivity scaling system, makes thing easier to manage while potentially introducting future input-related features like Flick Stick

@AL2009man AL2009man changed the title Decoupled Mouse Crosshair Speed {Aiming] from Mouse Speed [Camera] Decoupled Mouse Crosshair Speed [[Aiming] from Mouse Speed [Camera] May 29, 2025
@AL2009man AL2009man changed the title Decoupled Mouse Crosshair Speed [[Aiming] from Mouse Speed [Camera] Decoupled Mouse Crosshair Speed [Aiming] from Mouse Speed [Camera] May 29, 2025
@AL2009man AL2009man changed the title Decoupled Mouse Crosshair Speed [Aiming] from Mouse Speed [Camera] Decouples Mouse Crosshair Speed [Aiming] from Mouse Speed [Camera] May 29, 2025
AL2009man added 3 commits May 29, 2025 14:02
…r Mouse Sens

backported the unified Camera sens scale system from a separate PR over to here, while changing overall Crosshair Mouse scaling to closely mirror default mouse camera sens.
@AL2009man AL2009man marked this pull request as ready for review May 29, 2025 21:01
@AL2009man
Copy link
Author
AL2009man commented May 29, 2025

took some time adjusting of the Crosshair Mouse Speed scaling.

it should now be closer to the main Camera Mouse movement (at default 2.5 settings) while ensuring the muscle memory portion is consistent for those who are already gotten used to it. Thus: the final mouse crosshair speed default will be 2.50.

@AL2009man AL2009man marked this pull request as draft May 29, 2025 21:30
AL2009man added 2 commits May 29, 2025 18:00
found out a separate issue while revising the camera scaling, for now: this will be reverted back to how it was.
@AL2009man AL2009man marked this pull request as ready for review May 29, 2025 22:01
@fgsfdsfgs
Copy link
Owner

Please fix up the whitespace in all of your changes. Seems like you have it set to use two tabs instead of one for indents or something.

@AL2009man
Copy link
Author
AL2009man commented Jun 11, 2025

Please fix up the whitespace in all of your changes. Seems like you have it set to use two tabs instead of one for indents or something.

had to do last-minute whitespacing fix (i'm switching to Visual Studios Code), while doing regression fixes.

but I did found a bug. setting Mouse Camera to 0.00 causes Mouse Crosshair to not work. remnants of the old system. so i'll need to go ahead and get that fixed soonish (got IRL Stuffs to do, but I'll come back a bit later.)

edit: can't get it fixed, unfortunately. :(

@fgsfdsfgs
Copy link
Owner

but I did found a bug. setting Mouse Camera to 0.00 causes Mouse Crosshair to not work. remnants of the old system. so i'll need to go ahead and get that fixed soonish (got IRL Stuffs to do, but I'll come back a bit later.)

Well, if you set the sensitivity to 0, that's kind of expected, isn't it. Unless I'm misunderstanding.

Can you also nuke mouseaimspeedx and mouseaimspeedy from the extcfg struct since they're not used anymore?

@AL2009man
Copy link
Author

but I did found a bug. setting Mouse Camera to 0.00 causes Mouse Crosshair to not work. remnants of the old system. so i'll need to go ahead and get that fixed soonish (got IRL Stuffs to do, but I'll come back a bit later.)

Well, if you set the sensitivity to 0, that's kind of expected, isn't it. Unless I'm misunderstanding.

Can you also nuke mouseaimspeedx and mouseaimspeedy from the extcfg struct since they're not used anymore?

it should be replaced with the new version. it can't be exactly nuked, tho

@bangstk
Copy link
bangstk commented Jun 17, 2025

In my opinion the setup that makes the most sense is if only Mouse Speed affected the camera turning speed, and then Crosshair Speed was represented as a ratio on top of that, affecting only the crosshair position. That way you can set the Crosshair Speed to "1.0" to get the same crosshair position relative to current turning rate (in degrees per second) as the original game, regardless of what you have the Mouse Speed (Camera) set to.

Also, if you want to get testing/feedback from KB/M players it would be helpful if you provided some builds.

@AL2009man
Copy link
Author

Also, if you want to get testing/feedback from KB/M players it would be helpful if you provided some builds.

GitHub Action CI came to the rescue! (you can test out the build right now!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0