always use .test TLD for email domain names #483
Conversation
9f8d8fb to
1850a37
Compare
|
Hi @armadillojim! Thank you for this suggestion and sorry to hear that you got annoyed by those emails, but there are two things I'd like to say:
|
|
Thanks! I agree the use of the library ultimately is the responsibility of the developer. However, I feel that the library should be set up in such a way that by default it doesn't encourage harmful behavior. What about adding a parameter to |
|
Yes, I agree, but I believe such approach would be dublication of purpose of |
|
Ok, thanks! What about renaming |
|
Hard to tell if it's ok for those people. who already use these methods... We should create warnings for them for the next version about method name deprecation, and then rename methods for the following versions. Not a huge fun of such things. @marocchino, what do you think? |
|
@Volosh1n 🤔 How about support rails like config file? Version 2 was released six years ago, so it seems like the major release time has come. |
|
@marocchino sounds good, if there are plenty of things to be updated! |
Hello! Thank you for the wonderful testing library.
I have a domain name that uses my last name, and I frequently get test emails from developers' staging environments. This is endlessly annoying to me, and it potentially exposes companies' internal data when testing.
When I alert companies to this, they often thank me for telling them, but they are often clueless as to how such a thing happened. However, last month GitLab sent me a test email, and I when I alerted them, they were kind enough to ask their engineering team for the cause. It turns out they use ffaker to generate fake email addresses to test with. I can only imagine that many other companies do the same.
Would you be willing to change ffaker so that fake email addresses always use the
.testTLD? Perhaps throw in.exampleand.localif you want variety.I've created a PR here with one possible fix. I'm open to suggestions and feedback, and am willing to change my proposal.