Java support for literals in unions proposal #6822
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Java SDK generator doesn't have full support for literal types. We currently only support literals in objects, which are handled by having the generator hard-code the literal value into the getter method.
This is a proposal for how to handle literals in unions:
Discriminated Unions
Instead of taking in an argument in the constructor, pass in the value of the literal into the constructor ourselves, and only expose the label to the user, like in the case of no-properties union variants.
Undiscriminated Unions
Booleans
Handle like any other boolean
Strings
Expose a
visitLiteral(String)method with a javadoc listing all the possible options, and anofLiteral(String)which throws if the provided string is not one of the supported string literals.