8000 feat(bloc): add onCreate and onClose to BlocObserver by felangel · Pull Request #1832 · felangel/bloc · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(bloc): add onCreate and onClose to BlocObserver #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2020
Merged

feat(bloc): add onCreate and onClose to BlocObserver #1832

merged 3 commits into from
Oct 15, 2020

Conversation

felangel
Copy link
Owner
@felangel felangel commented Oct 15, 2020 •
edited
Loading

Status

READY

Breaking Changes

NO

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added enhancement New feature or request release candidate Candidate for release pending successful build pkg:bloc This issue is related to the bloc package labels Oct 15, 2020
@felangel felangel self-assigned this Oct 15, 2020
@felangel felangel requested a review from jorgecoca October 15, 2020 04:57
@felangel felangel force-pushed the feat/bloc-onCreate-onClose branch from ac42ee7 to 9b639e4 Compare October 15, 2020 05:00
@codecov
Copy link
codecov bot commented Oct 15, 2020 •
edited
Loading

Codecov Report

Merging #1832 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1832   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           96       100    +4     
=========================================
+ Hits            96       100    +4
Impacted Files Coverage Δ
packages/bloc/lib/src/bloc.dart 100.00% <ø> (ø)
packages/bloc/lib/src/bloc_observer.dart 100.00% <100.00%> (ø)
packages/bloc/lib/src/cubit.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fad25b...67d96bf. Read the comment docs.

@felangel felangel force-pushed the feat/bloc-onCreate-onClose branch from 9b639e4 to 2068217 Compare October 15, 2020 05:16
@jorgecoca
Copy link
Collaborator

Changes LGTM. Maybe I would expand the documentation with a use case that would explain when/how those lifecycle methods would be necessary

@felangel felangel force-pushed the feat/bloc-onCreate-onClose branch from 2068217 to f73c7f7 Compare October 15, 2020 15:39
@felangel felangel merged commit ceaee86 into master Oct 15, 2020
@felangel felangel deleted the feat/bloc-onCreate-onClose branch October 15, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

Assignees

@felangel felangel

Labels
enhancement New feature or request pkg:bloc This issue is related to the bloc package release candidate Candidate for release pending successful build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two new BlocObserver callbacks: onCreate, onDispose
2 participants
@felangel @jorgecoca
0