fix(intellij): add dart sdk constraint to language server #4469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
reviewed
May 5, 2025
...rc/main/java/com/bloc/intellij_generator_plugin/language_server/BlocLanguageServerFactory.kt
Outdated
Show resolved
Hide resolved
felangel
reviewed
May 5, 2025
| import kotlin.test.assertFalse | ||
| import kotlin.test.assertTrue | ||
|
|
||
| class VersionComparatorTest { |
felangel
reviewed
May 5, 2025
| } | ||
|
|
||
| override fun setEnabled(enabled: Boolean, project: Project) { | ||
| // TODO: Implement this with settings |
There was a problem hiding this comment.
Are you leaving this todo intentionally?
There was a problem hiding this comment.
As you can see on the documentation of LSP4IJ, this setter is for permitting to add an option to programmatically set on and off the LSP. We gonna use it to add an option to disable the LSP in near future but it's outside of this PR scope i think.
|
Little refactor added |
felangel
reviewed
May 6, 2025
| @@ -63,4 +71,31 @@ class BlocLanguageServerFactory : LanguageServerFactory { | |||
| .createNotification(content, type) | |||
| .notify(project) | |||
| } | |||
|
|
|||
| override fun isEnabled(project: Project): Boolean { | |||
| val blocToolsVersion = getBlocToolsVersion() | |||
There was a problem hiding this comment.
Looks like this method is being called many times and results in a really laggy user experience so we should probably rework this.
There was a problem hiding this comment.
Ok, i gonna check to clean this tomorrow.
felangel
reviewed
May 7, 2025
...lugin/src/main/java/com/bloc/intellij_generator_plugin/language_server/BlocLanguageServer.kt
Outdated
Show resolved
Hide resolved
felangel
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Breaking Changes
NO
Description
Fix #4468 for IntelliJ
Type of Change