Updates ocfl-java to 1.5.0 #53
Conversation
| @@ -1637,6 +1638,7 @@ private void assertVersions(final List<OcflVersionInfo> actual, final String... | |||
| final var versionNums = actual.stream() | |||
| .map(OcflVersionInfo::getVersionNumber) | |||
| .collect(Collectors.toList()); | |||
| sort(versionNums); | |||
There was a problem hiding this comment.
Instead of sorting here, you could change the next line to:
assertThat(versionNums, containsInAnyOrder(expected));There was a problem hiding this comment.
Thanks @pwinckles : I'll change it.
40e6ff7 to
8506d2b
Compare
|
I haven't checked to see if there's been any discussion of this, but after this upgrade ocfl-java will create ocfl 1.1 repositories by default. It will not "upgrade" existing repositories to 1.1 without explicitly asking it to. I'm not sure if you do or don't want to enable users to upgrade the repo. Honestly, I don't think there's really much reason to "upgrade". 1.0 and 1.1 are functionally equivalent. |
|
We haven't discussed that, but I agree and see no reason to upgrade. OCFL being immutable and made for long-term preservation means that items in a repository could (and probably will) contain a multitude of versions. |
After this update, an existing repository would not start creating 1.1 objects. It would still be 1.0 objects only, even new objects. However, newly created repositories would use 1.1 and create 1.1 objects. You can configure ocfl-java to either upgrade existing repositories to 1.1 and create new objects as 1.1 (existing objects remain unchanged), or upgrade the repo and upgrade existing objects when they are next written to. Neither of these upgrade options are enabled by default. |
Resolves: https://fedora-repository.atlassian.net/browse/FCREPO-3857
Updates ocfl-java to 1.5.0
JIRA Ticket: https://github.com/dbernstein/fcrepo-storage-ocfl/pull/new/FCREPO-3857
What does this Pull Request do?
No functional changes.
How should this be tested?
A description of what steps someone could take to:
Interested parties
Tag (@ mention) interested parties or, if unsure, @fcrepo/committers