8000 use memento created when touching related resources by pwinckles · Pull Request #46 · fcrepo/fcrepo-storage-ocfl · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

use memento created when touching related resources #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2021
Merged

use memento created when touching related resources #46

merged 1 commit into from
Oct 15, 2021

Conversation

pwinckles
Copy link
Collaborator
@pwinckles pwinckles commented Oct 15, 2021 •
edited
Loading

JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3786

What does this Pull Request do?

Updates the code to use the memento created timestamp when touching related resources, resolving a bug where mementos were not being created on related resources when the last updated timestamp was the same as the existing memento created timestamp.

How should this be tested?

  1. Create a binary resource
  2. Create a memento on the binary description
  3. List the binary's mementos and see that a memento was created on it

Interested parties

@fcrepo/committers

@pwinckles pwinckles mentioned this pull request Oct 15, 2021
Merged
dbernstein
dbernstein approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor
@dbernstein dbernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with the fcrepo PR - works as expected.

@dbernstein dbernstein merged commit 2f8a446 into fcrepo:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbernstein dbernstein dbernstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwinckles @dbernstein
0