Do not write headers until commit #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3771
What does this Pull Request do?
When creating binaries a binary resource and a binary description are created. Due to how the "touching" works, this was resulting in the binary's resources headers being serialized to disk multiple times. This change resolves the problem by deferring the serialization of any headers until the session is committed.
This improves write latency on systems with slow IO.
How should this be tested?
Everything should work the same as before, and creating binary resources should be faster.
Interested parties
@fcrepo/committers