I added more options to PhotonVRManager I might change some scripts later but this is what I got. #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am adding some stuff to PhotonVRManager. |
|
I also also ALSO added a TMP that you can assign and it will say what's going on. [Tooltip("Basically a tmp that says what PhotonVRManager is doing.")]
public static TextMeshPro LogText; if (Manager == null)
{
Manager = this;
Manager.State = ConnectionState.Setting_Up_Settings;
LogText.text = "Setting Up Settings..."; //Here
PhotonNetwork.PhotonServerSettings.DevRegion = DevRegion;
}
else if (StartInOfflineMode == true)
{
PhotonNetwork.PhotonServerSettings.StartInOfflineMode = true;
}
else if (StartInOfflineMode == false)
{
PhotonNetwork.PhotonServerSettings.StartInOfflineMode = false;
}
else
{
Debug.LogError("There can't be multiple PhotonVRManagers in a scene");
Manager.State = ConnectionState.Error;
LogText.text = "ERROR: There can't be multiple PhotonVRManagers in a scene."; //Also here
Application.Quit();
} |
| @@ -271,13 +226,36 @@ public static void SetCosmetics(Dictionary<string, string> PlayerCosmetics) | |||
| /// Sets a specefic cosmetic | |||
| /// </summary> | |||
| /// <param name="Type">The type of cosmetic you want to set</param> | |||
| public static void SetCosmetic(string Type, string CosmeticId) | |||
| public static void SetCosmetic(CosmeticType Type, string CosmeticId) | |||
There was a problem hiding this comment.
this entire function should never have been changed
There was a problem hiding this comment.
I think that was bc I changed photon vr version 0.0.5 or 0.0.4
| @@ -421,6 +407,10 @@ public enum ConnectionState | |||
| Connecting, | |||
| Connected, | |||
| JoiningRoom, | |||
| InRoom | |||
| InRoom, | |||
| Error, | |||
There was a problem hiding this comment.
the cases under the error case are just not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer
Fchb1239 please check my code if it works. I'm not perfect at coding.
There might be some bugs in the code. Please have mercy with me.
I tested it in my game and it worked.
I only edited PhotonVRManager so just copy and paste this into your PhotonVRManager.
Stuff I added
I added a dev region choice. Meaning if your apk is a development build, it's going to connect to the dev region.
I also added a Offline mode bool. Meaning that it simulates an online connection. PUN can be used as if it was in an online connection.
I also also added more connection states for more debugging.
I just basically made it more easy so you don't have to go manually into the Photon server settings and just be able to control Photon from one script.