8000 Update screenshot by tovbinm · Pull Request #94 · faros-ai/faros-events-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update screenshot #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

Update screenshot #94

merged 1 commit into from
Oct 17, 2022

Conversation

tovbinm
Copy link
Contributor
@tovbinm tovbinm commented Oct 17, 2022

No description provided.

@tovbinm tovbinm requested review from willmarks and cjwooo October 17, 2022 18:52
willmarks
willmarks approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator
@willmarks willmarks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference? Just png to jpg? Also should we indicate in the picture that Build Started & Build Ended can be more than one by saying CI Event(s) or something like that?

@tovbinm
Copy link
Contributor Author
tovbinm commented Oct 17, 2022

The difference is the background. We should, need to create a new image. Merging for now.

@tovbinm tovbinm merged commit f1286c0 into main Oct 17, 2022
@tovbinm tovbinm deleted the mt/screenshot branch October 17, 2022 19:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willmarks willmarks willmarks approved these changes

@cjwooo cjwooo Awaiting requested review from cjwooo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tovbinm @willmarks
0