[fastlane_core] recognize AWS CodeBuild CI service as a CI environment #29237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshanjain
approved these changes
Jan 10, 2025
…tput directory path
This was referenced Jan 18, 2025
|
Note for approvers: please also check the changes in the doc |
|
Thank you Felix ! |
|
Hey Felix, just wondering about when we can expect these changes to released. |
|
Since there is no financial support from any company towards fastlane, there aren't any activate maintainers, hence there is no release cadence, and currently a rather large time investment by someone to do the release. If AWS is interested in a small monthly contribution, I'm happy to help set something up. I still believe there is a way to have some base-level of financial contribution, which would allow the fastlane team to do monthly releases + hotfix releases, and keep things running smoothly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
This PR helps fastlane recognize AWS CodeBuild as CI service enabling CodeBuild customers to use fastlane.
Description
Added CodeBuild env variable to the list of environment variable to check if the request is coming from CI service.
Tested running the
bundle exec rspeccommand locally. Also tested internally on CodeBuild system.