✨Adds the ability to use union in type signatures #1148
Conversation
4990e72 to
639de2b
Compare
|
I am setting this to draft for now since I have no idea whether what I did is enough, I'll happily convert this to a merge request once someone will give me the OK. |
|
@svlandeg I don't mean to be rude, but is there any progress on getting this in? |
|
Hi @arielf212, thanks for your contribution adding this feature and an appropriate test! 🙏 We're currently working through a bit of a backlog of PRs, so unfortunately it may take a little while to get this properly reviewed by the team. We've put it on our internal board though, so we'll let you know here once we've been able to go through it in detail. Thanks for your patience! |
|
In the meantime, what would be helpful is if you can update the test suite to test all new lines of code, so that the coverage of the code base is back to 100% and the CI goes green again 🙏 |
|
can outside folks contribute to this pr? I'd be happy to take a stab at writing the rest of the tests if that helps |
This PR adds the ability to use real unions (a la
Union[int, str]), as requested in #461.I am new to contributing to this Repository, and I'll happily add anything I might have missed (docs/tests/incorrect code location/etc).