8000 🌐 Add Korean translation for `docs/ko/docs/advanced/wsgi.md` by Limsunoh · Pull Request #12659 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for docs/ko/docs/advanced/wsgi.md #12659

Merged
merged 9 commits into from
Oct 31, 2024

Conversation

Limsunoh
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the lang-all Translations label Oct 28, 2024
Copy link
Contributor

@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Oct 28, 2024
@alejsdev alejsdev changed the title Add translation to docs/ko/docs/advanced/wsgi.md 🌐 Add Korean Translation for docs/ko/docs/advanced/wsgi.md Oct 28, 2024
@alejsdev alejsdev changed the title 🌐 Add Korean Translation for docs/ko/docs/advanced/wsgi.md 🌐 Add Korean translation for docs/ko/docs/advanced/wsgi.md Oct 28, 2024
Copy link
Contributor
@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! However, some points need improvement. I believe reading others' translations will help you.

docs/ko/docs/advanced/wsgi.md Outdated Show resolved Hide resolved
docs/ko/docs/advanced/wsgi.md Outdated Show resolved Hide resolved
docs/ko/docs/advanced/wsgi.md Outdated Show resolved Hide resolved
docs/ko/docs/advanced/wsgi.md Outdated Show resolved Hide resolved
docs/ko/docs/advanced/wsgi.md Outdated Show resolved Hide resolved
docs/ko/docs/advanced/wsgi.md Outdated Show resolved Hide resolved
Copy link
@sodaMelon sodaMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Limsunoh i left some comment to read better.
번역에서는 기본적으로 ~습니다 를 쓰게되어있어서
어투만 교정했습니다.
나머지는 @hard-coders 님 코멘트를 확인하세요!

Limsunoh and others added 2 commits October 31, 2024 16:57
Co-authored-by: hy.lee <rurouni24@gmail.com>
Co-authored-by: hy.lee <rurouni24@gmail.com>
Copy link
Contributor

Limsunoh and others added 3 commits October 31, 2024 17:09
Co-authored-by: hy.lee <rurouni24@gmail.com>
Co-authored-by: hy.lee <rurouni24@gmail.com>
"Thank you for explaining it so well

Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Copy link
Contributor

Copy link
Contributor

Copy link
@sodaMelon sodaMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Copy link
Contributor
@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@alejsdev alejsdev enabled auto-merge (squash) October 31, 2024 18:56
@alejsdev alejsdev merged commit 14b087c into fastapi:master Oct 31, 2024
56 checks passed
@alejsdev
Copy link
Member

Nice, thank you! @Limsunoh 🥳
And thanks for the reviews @hard-coders @sodaMelon 🎉

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0