8000 🌐 Add Korean translation for `/docs/ko/docs/environment-variables.md` by Tolerblanc · Pull Request #12526 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Korean translation for /docs/ko/docs/environment-variables.md #12526

Merged
merged 5 commits into from
Nov 7, 2024
Merged

🌐 Add Korean translation for /docs/ko/docs/environment-variables.md #12526

merged 5 commits into from
Nov 7, 2024

Conversation

Tolerblanc
Copy link
Contributor

Add Korean Translation for /docs/ko/docs/environment-variables.md

@github-actions github-actions bot added the lang-all Translations label Oct 24, 2024
@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Oct 24, 2024
@sodaMelon
Copy link
sodaMelon commented Oct 24, 2024 •
edited
Loading

@alejsdev hi, could you re-check with github-actions?
new page is not being created in this PR

@tiangolo tiangolo mentioned this pull request Oct 24, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit b5fd7ff at: https://3f1da638.fastapitiangolo.pages.dev

Modified Pages

@tiangolo
Copy link
Member

Thanks @sodaMelon! The problem with the missing previews was handled here #12527

@sodaMelon
Copy link

Thanks @sodaMelon! The problem with the missing previews was handled here #12527

oh hi @tiangolo, thanks!!! what a awesome speed lmao
have a nice day

sodaMelon
sodaMelon reviewed Oct 26, 2024
View reviewed changes
Copy link
@sodaMelon sodaMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi.
To make sure your sentences read naturally and clearly, i left some suggestions.

@Tolerblanc @sodaMelon
Apply suggestions from code review
213d5b1 
- correct ambiguous expressions clearly and readably

Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
@Tolerblanc
Copy link
Contributor Author

@sodaMelon Thank you for your detailed review! I have revised everything you pointed out.

@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 213d5b1 at: https://868dd35f.fastapitiangolo.pages.dev

Modified Pages

sodaMelon
sodaMelon approved these changes Oct 27, 2024
View reviewed changes
Copy link
@sodaMelon sodaMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sodaMelon
Copy link
8000

hi @hard-coders @JaeHyuckSa
could you review this PR?

hard-coders
hard-coders reviewed Nov 1, 2024
View reviewed changes
docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/ko/docs/environment-variables.md Outdated Show resolved Hide resolved
Tolerblanc and others added 2 commits November 2, 2024 14:36
@Tolerblanc
Copy link
Contributor Author

@hard-coders Thank you for your review! I corrected the ambiguous parts and the parts written Python to 파이썬.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Nov 2, 2024

📝 Docs preview for commit bc24db7 at: https://079faa4c.fastapitiangolo.pages.dev

Modified Pages

hard-coders
hard-coders approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor
@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@alejsdev alejsdev enabled auto-merge (squash) November 7, 2024 20:48
@alejsdev
Copy link
Member
alejsdev commented Nov 7, 2024

Thanks everyone for the help! @Tolerblanc @sodaMelon @hard-coders 🙌

@alejsdev alejsdev merged commit d28bae0 into fastapi:master Nov 7, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sodaMelon sodaMelon sodaMelon approved these changes

@hard-coders hard-coders hard-coders approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-ko Korean translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tolerblanc @sodaMelon @tiangolo @alejsdev @hard-coders
0