8000 🌐 Add Dutch translation for `docs/nl/docs/environment-variables.md` by maxscheijen · Pull Request #12200 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Dutch translation for docs/nl/docs/environment-variables.md #12200

Merged
merged 2 commits into from
Sep 20, 2024
Merged

🌐 Add Dutch translation for docs/nl/docs/environment-variables.md #12200

merged 2 commits into from
Sep 20, 2024

Conversation

maxscheijen
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the lang-all Translations label Sep 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit a294710 at: https://af0144fd.fastapitiangolo.pages.dev

Modified Pages

@alejsdev alejsdev added awaiting-review lang-nl Dutch translations labels Sep 14, 2024
@svlandeg svlandeg self-requested a review September 16, 2024 08:01
svlandeg
svlandeg reviewed Sep 16, 2024
View reviewed changes
Copy link
Member
@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another great translation!

I confirmed that this Dutch translation accurately reflects the current English page, and the translation reads really well in general.

I just added a few nitpicking comments as usual 😉

docs/nl/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/nl/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/nl/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/nl/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/nl/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/nl/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/nl/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/nl/docs/environment-variables.md Outdated Show resolved Hide resolved
docs/nl/docs/environment-variables.md Outdated Show resolved Hide resolved
@maxscheijen @svlandeg
Apply suggestions from code review by @svlandeg
80f38c9 
Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 80f38c9 at: https://dc8cc3a5.fastapitiangolo.pages.dev

Modified Pages

svlandeg
svlandeg approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member
@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks again!

@alejsdev alejsdev merged commit 6aefc31 into fastapi:master Sep 20, 2024
56 checks passed
@alejsdev
Copy link
Member

Thanks for your PR @maxscheijen 🚀
And big thanks to @svlandeg for reviewing! ✨

@maxscheijen maxscheijen deleted the feat/dutch-environment-variables branch September 20, 2024 15:54
s-rigaud 7B1A pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
@maxscheijen @s-rigaud
🌐 Add Dutch translation for docs/nl/docs/environment-variables.md (f…
83de349 
…astapi#12200)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
approved-1 lang-all Translations lang-nl Dutch translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxscheijen @alejsdev @svlandeg
0