8000 💚 Set `include-hidden-files` to `True` when using the `upload-artifact` GH action by svlandeg · Pull Request #12118 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Set include-hidden-files to True when using the upload-artifact GH action #12118

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

svlandeg
Copy link
Member
@svlandeg svlandeg commented Sep 2, 2024

The CI was failing because hidden files are automatically excluded since actions/upload-artifact v4.4.0.

This PR specifically sets the parameter to True so the .coverage files are found.

@svlandeg svlandeg changed the title 💚 Set nclude-hidden-files when uploading coverage files 💚 Set include-hidden-files to True when uploading coverage files Sep 2, 2024
@svlandeg
Copy link
Member Author
svlandeg commented Sep 2, 2024

There's one more occurrence of this action in the build-docs.yml, but I think we can stick to the defaults for that one?

@svlandeg svlandeg changed the title 💚 Set include-hidden-files to True when uploading coverage files 💚 Set include-hidden-files to True when uploading coverage files in the CI Sep 2, 2024
@tiangolo
Copy link
Member
tiangolo commented Sep 2, 2024

Nice! Thank you! 🚀

Can you do it in build-docs.yml too? Those generate a .cache directory with social preview images for each page... I'm not sure if those files are used or not, but better to be safe.

@svlandeg svlandeg changed the title 💚 Set include-hidden-files to True when uploading coverage files in the CI 💚 Set include-hidden-files to True when uploading coverage files in the CI Sep 2, 2024
Copy link
Member
@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you! 🚀

@svlandeg svlandeg changed the title 💚 Set include-hidden-files to True when uploading coverage files in the CI 💚 Set include-hidden-files to True when using the upload-artifact GH action Sep 2, 2024
@svlandeg svlandeg merged commit b63b418 into fastapi:master Sep 2, 2024
49 checks passed
@svlandeg svlandeg deleted the fix/gh_action branch September 2, 2024 19:53
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
…t` GH action (fastapi#12118)

* include-hidden-files when uploading coverage files

* include-hidden-files when building docs
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
…t` GH action (fastapi#12118)

* include-hidden-files when uploading coverage files

* include-hidden-files when building docs
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
…t` GH action (fastapi#12118)

* include-hidden-files when uploading coverage files

* include-hidden-files when building docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0