8000 🌐 Update Chinese translation for `docs/zh/docs/how-to/index.md` by synthpop123 · Pull Request #12070 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Update Chinese translation for docs/zh/docs/how-to/index.md #12070

Merged
merged 3 commits into from
Aug 28, 2024
Merged

🌐 Update Chinese translation for docs/zh/docs/how-to/index.md #12070

merged 3 commits into from
Aug 28, 2024

Conversation

synthpop123
Copy link
Contributor

The ε°ζŠ€ε·§ label in the admonition was causing rendering issues in MkDocs, so replacing it with the standard tip label fixes this problem.

@github-actions github-actions bot added the lang-all Translations label Aug 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

πŸ“ Docs preview for commit 311ce3f at: https://e37ff060.fastapitiangolo.pages.dev

Modified Pages

@alejsdev alejsdev added lang-zh Chinese translations awaiting-review labels Aug 25, 2024
@alejsdev
Copy link
Member

Hi @synthpop123, you're right! This is an error, but we usually prefer to keep the original (for the styling) and the translation, so it would be something more like this:

/// tip | translated-word

Could you update it, please? πŸ˜„

Thank you πŸ™‡β€β™€οΈ

@github-actions GitHub Actions
Copy link
Contributor

πŸ“ Docs preview for commit 6716d9a at: https://03b0bb5b.fastapitiangolo.pages.dev

Modified Pages

@synthpop123
Copy link
Contributor Author

Hi @synthpop123, you're right! This is an error, but we usually prefer to keep the original (for the styling) and the translation, so it would be something more like this:

/// tip | translated-word

Could you update it, please? πŸ˜„

Thank you πŸ™‡β€β™€οΈ

Thank you for the quick review! I’ve updated the PR with the suggested change.

@github-actions GitHub Actions
Copy link
Contributor

πŸ“ Docs preview for commit 4169efb at: https://c41598d2.fastapitiangolo.pages.dev

Modified Pages

svlandeg
svlandeg approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member
@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks! πŸ™

@alejsdev alejsdev merged commit f41f623 into fastapi:master Aug 28, 2024
55 checks passed
@ 8000 alejsdev
Copy link
Member

Thank you! @synthpop123 @svlandeg πŸŽ‰

black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
@synthpop123 @black-redoc
🌐 Update Chinese translation for docs/zh/docs/how-to/index.md (fast…
41ae8cb 
…api#12070)
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
@synthpop123 @black-redoc
🌐 Update Chinese translation for docs/zh/docs/how-to/index.md (fast…
e617a07 
…api#12070)
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
@synthpop123 @black-redoc
🌐 Update Chinese translation for docs/zh/docs/how-to/index.md (fast…
774afbf 
…api#12070)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aruelius Aruelius Aruelius approved these changes

@svlandeg svlandeg svlandeg approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-zh Chinese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@synthpop123 @alejsdev @svlandeg @Aruelius
0