-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Dutch translation for docs/nl/docs/index.md
#12042
Conversation
📝 Docs preview for commit 4774217 at: https://b4009269.fastapitiangolo.pages.dev Modified Pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Sofie, thanks for the translation effort!
As a native Dutch speaker and developer, I always feel a bit awkward reading Dutch programming-documentation, so my main feedback would be that it would be a bit of a waste of time as you need a proper understanding of English anyway if you want to develop effectively. Also; adding a translation increases the workload of keeping all translations in sync if the main source is changed. I am inclined to the less-is-more.
However it might be worth the effort to some ppl!
My main feedback is that 'high performance' does not have a proper Dutch translation. "hoogwaardige prestatie" might be the most accurate translation, "(zeer) goede prestaties" somewhat feels better.
(ps I see you are from Belgium so probably used to Flemish? that might explain some sentences that feel a bit off in Dutch from the Netherlands)
Thanks for the review @d2a-raudenaerde!
Totally agree! I find these super awkward myself. Still, FastAPI has been offering translations in various languages for some time now, and I do think it may help lower the barrier for non-native English speaking people. I wanted Dutch to be at least represented 😉
I used this suggestion to make some edits ^^
Yep I'm indeed Flemish. Feel free to mark specific sentences you feel are "off" and/or suggest alternatives. I have the same when I read translations from people from the Netherlands though, there's always going to be a slight difference in language usage 🙈 |
📝 Docs preview for commit 304aaa9 at: https://e57ad853.fastapitiangolo.pages.dev Modified Pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paar kleine punten
📝 Docs preview for commit d4afbc0 at: https://68633c7f.fastapitiangolo.pages.dev Modified Pages |
📝 Docs preview for commit 9f6f4c2 at: https://f0b58d69.fastapitiangolo.pages.dev Modified Pages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lijkt me mooi zo! - Looks good to me ;)
Awesome, thank you @svlandeg! 🚀 And thanks @d2a-raudenaerde for the reviews and help! 🍰 |
Co-authored-by: Max Scheijen <maxscheijen@gmail.com>
Co-authored-by: Max Scheijen <maxscheijen@gmail.com>
Co-authored-by: Max Scheijen <maxscheijen@gmail.com>
Co-authored-by: Max Scheijen <maxscheijen@gmail.com>
This PR builds upon the previous efforts by @maxscheijen and his original PR #5366.
I applied the reviewer comments and updated the page with the latest changes from
master
.As a native Dutch speaker myself, I went through the text and added a few more fixes as well.