-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Update docs_src/path_params_numeric_validations/tutorial006.py
#11478
Conversation
The size parameter was not appended into the results.
📝 Docs preview for commit 4254b2c at: https://dcbd9b93.fastapitiangolo.pages.dev |
The size parameter was not appended to results
The size parameter was not appended to results
📝 Docs preview for commit 83684df at: https://7abfa613.fastapitiangolo.pages.dev |
docs_src/path_params_numeric_validations/tutorial006.py
📝 Docs preview for commit e31090d at: https://9d7f0a09.fastapitiangolo.pages.dev |
📝 Docs preview for commit e5695b3 at: https://61df5171.fastapitiangolo.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Adding the size
parameter to the results
makes sense because then at least the body of the function is doing something with this value. Mostly this part of the tutorial is about using the gt
and lt
annotations in Query
, so it doesn't matter much either way, but this edit doesn't hurt 🙂
Thanks again!
Cool, thanks @MuhammadAshiqAmeer! ☕ And thanks @svlandeg 🍰 |
…astapi#11478) Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
…astapi#11478) Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
…astapi#11478) Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
…astapi#11478) Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
The size parameter was not appended into the results.