📝 Several docs improvements, tweaks, and clarifications #11390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nilslindemann, thanks for the PR! Especially appreciate you breaking out more ambiguous changes into its separate PR & commit - these kind of considerations certainly help us push "less ambiguous" fixes through more easily 🙏 I'll get this PR updated with the latest of |
svlandeg
reviewed
Aug 14, 2024
|
Awesome, thanks a lot for this @nilslindemann! 🚀 You rock! 🎸 And thanks a lot @svlandeg for the thorough review! 🙇 I tweaked a couple of places and included Sofie's suggestions, this is now ready. Thank you! 🍰 |
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Aug 16, 2024
Co-authored-by: svlandeg <svlandeg@github.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Aug 17, 2024
Co-authored-by: svlandeg <svlandeg@github.com> Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
|
Thanks people, especially @svlandeg! I know this was quite some work. Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are more ambiguous changes subtracted from #11389. Smaller PR, but look more closely. The first two commits are improvements in my opinion. I am unsure about the third commit.