8000 🌐 Add Russian translation for `docs/ru/docs/tutorial/security/simple-oauth2.md` by AlertRED · Pull Request #10599 · fastapi/fastapi · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Russian translation for docs/ru/docs/tutorial/security/simple-oauth2.md #10599

Merged
merged 11 commits into from
Dec 10, 2024
Merged

🌐 Add Russian translation for docs/ru/docs/tutorial/security/simple-oauth2.md #10599

merged 11 commits into from
Dec 10, 2024

Conversation

AlertRED
Copy link
Contributor
@AlertRED AlertRED commented Nov 6, 2023

No description provided.

@alejsdev alejsdev added lang-all Translations lang-ru Russian translations awaiting-review labels Jan 8, 2024
@codespearhead
Copy link

Do you happen to know three Russian developers you can ask a PR review from? This might help.

@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 3cbb662 at: https://fae08884.fastapitiangolo.pages.dev

Modified Pages

alv2017
alv2017 suggested changes Nov 22, 2024
View reviewed changes
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 776fec5 at: https://c88a9489.fastapitiangolo.pages.dev

Modified Pages

@AlertRED AlertRED requested a review from alv2017 November 25, 2024 13:19
@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 886736d at: https://4561dbaa.fastapitiangolo.pages.dev

Modified Pages

alv2017
alv2017 suggested changes Nov 25, 2024
View reviewed changes
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated

А ваши модели баз данных могут использовать любые другие имена.

Но при авторизации в *эндпоинте* нам необходимо использовать именно эти имена, чтобы соответствовать спецификации (и иметь возможность, например, использовать это во встроенной системе документации API).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Но при авторизации в *эндпоинте* нам необходимо использовать именно эти имена, чтобы соответствовать спецификации (и иметь возможность, например, использовать это во встроенной системе документации API).
Но при авторизации, согласно спецификации, требуется использовать именно эти имена. (Это даст нам возможность, воспользоваться встроенной системой документации API).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alv2017 Только в этом предложении немного изменил ваш вариант

docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
@alv2017
Copy link
Contributor
alv2017 commented Nov 25, 2024

@Xewus, @s111d нужна помощь с ревью. Подключайтесь!
👋 😊

alv2017
alv2017 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor
@alv2017 alv2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дополнительно добавила предложения по улучшению перевода (на твое усмотрение)

@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 94b9c4b at: https://ab994b0d.fastapitiangolo.pages.dev

Modified Pages

@alejsdev
Copy link
Member

Hi @AlertRED, I have updated the documentation with the latest syntax for includes.
I will wait for you to review the changes suggested by @alv2017 before merging the PR.
Thanks to both of you for the help! 🚀

AlertRED and others added 3 commits November 28, 2024 19:06
@AlertRED @alv2017
Apply suggestions from code review
0224ff6 
Co-authored-by: alv2017 <v.alishauskaite@gmail.com>
@AlertRED
Merge branch 'master' into simple-oauth2-russian-translation
8f430ab
@AlertRED @alv2017
Apply suggestions from code review
50e7a4c 
Co-authored-by: alv2017 <v.alishauskaite@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 50e7a4c at: https://201715b7.fastapitiangolo.pages.dev

Modified Pages

@alv2017
Copy link
Contributor
alv2017 commented Nov 28, 2024

@alejsdev: Thank you for your help!

@AlertRED: I think we are ready with PR, aren't we?

😃

@github-actions github-actions bot removed the waiting label Nov 28, 2024
@AlertRED
Copy link
Contributor Author

@alejsdev: Thank you for your help!

@AlertRED: I think we are ready with PR, aren't we?

😃

Yes, we are :)

Xewus
Xewus suggested changes Nov 30, 2024
View reviewed changes
Copy link
Contributor
@Xewus Xewus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом, проделанный объё 9E88 м работы большой.

docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md Outdated Show resolved Hide resolved
docs/ru/docs/tutorial/security/simple-oauth2.md < F438 span title="Label: Outdated" data-view-component="true" class="Label Label--secondary"> Outdated Show resolved Hide resolved
@AlertRED @Xewus
Apply suggestions from code review
50fe7ca 
Co-authored-by: Vladislav Kramorenko <85196001+Xewus@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 50fe7ca at: https://bc59d32c.fastapitiangolo.pages.dev

Modified Pages

@AlertRED AlertRED requested a review from Xewus November 30, 2024 10:20
@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit ef57e36 at: https://1adbc81e.fastapitiangolo.pages.dev

Modified Pages

alv2017
alv2017 reviewed Nov 30, 2024
View reviewed changes
Copy link
Contributor
@alv2017 alv2017 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У меня возражение по поводу строки 135: scope vs scopes

#10599 (comment)

@github-actions GitHub Actions
Copy link
Contributor

📝 Docs preview for commit 967ca0a at: https://19725d65.fastapitiangolo.pages.dev

Modified Pages

@alv2017
Copy link
Contributor
alv2017 commented Nov 30, 2024

Проблема решена, у меня никаких возражений больше нет 😃

@alejsdev alejsdev merged commit a54e336 into fastapi:master Dec 10, 2024
56 checks passed
@alejsdev
Copy link
Member

Great! Thanks for your work @AlertRED @Xewus @alv2017 🚀 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alv2017 alv2017 alv2017 approved these changes

@Xewus Xewus Xewus approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-ru Russian translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AlertRED @codespearhead @alv2017 @alejsdev @Xewus @tiangolo
0