8000 #3260 Added NotImplementedError in MixHandler for Non-Classification … by Shashank1202 · Pull Request #4045 · fastai/fastai · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

#3260 Added NotImplementedError in MixHandler for Non-Classification … #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#3260 Added NotImplementedError in MixHandler for Non-Classification … #4045

wants to merge 1 commit into from

Conversation

Shashank1202
Copy link

Added NotImplementedError in MixHandler for Non-Classification Problems

This enhancement adds a validation step in the MixHandler class to check if the block type is a classification block. If it’s not, the code raises a NotImplementedError, informing users that only CategoryBlock/SingleLabel classification is currently supported.

Closes #3260

@Shashank1202 Shashank1202 requested a review from jph00 as a code owner August 27, 2024 17:58
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@jph00
Copy link
Member
jph00 commented Aug 27, 2024

Thank you. Please run nbdev_export so the module is in sync.

RahulVadisetty91
RahulVadisetty91 reviewed Sep 11, 2024
View reviewed changes
Copy link
@RahulVadisetty91 RahulVadisetty91 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Check that comments and docstrings are clear and provide useful information. They should explain the purpose of the code and how to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RahulVadisetty91 RahulVadisetty91 RahulVadisetty91 left review comments

@jph00 jph00 Awaiting requested review from jph00 jph00 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Warning to MixHandler for Non Classification Problems (Enhancement)
3 participants
@Shashank1202 @jph00 @RahulVadisetty91
0