feat(userspace/libsinsp)!: remove sinsp::{add, remove}_thread()
#2391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the end goal is to remove unneeded duties from `sinsp`, remove `sinsp::add_thread()` API and let users directly call the corresponding thread manager API. BREAKING CHANGE: remove `sinsp::add_thread()` Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
As the end goal is to remove unneeded duties from `sinsp`, remove `sinsp::remove_thread()` API and let users directly call the corresponding thread manager API. BREAKING CHANGE: remove `sinsp::remove_thread()` Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2391 +/- ##
=======================================
Coverage 77.18% 77.18%
=======================================
Files 231 231
Lines 30357 30359 +2
Branches 4658 4658
=======================================
+ Hits 23430 23432 +2
Misses 6927 6927
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM label has been added. Git tree hash: a771a3c57f91981126a21ec7089c32d36f235d32
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.21.0 |
leogr
approved these changes
May 6, 2025
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/kind design
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR is part of a series #2343.
It removes
sinsp::add_thread()andsinsp::remove_thread()APIs. As the end goal is to remove unneeded duties fromsinsp, it removes these APIs and let users directly call the corresponding thread manager APIs.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: