8000 feat(userspace/libsinsp)!: remove unused `sinsp_evt::clone_event()` by ekoops · Pull Request #2377 · falcosecurity/libs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(userspace/libsinsp)!: remove unused sinsp_evt::clone_event() #2377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

feat(userspace/libsinsp)!: remove unused sinsp_evt::clone_event() #2377

merged 1 commit into from
Apr 29, 2025

Conversation

ekoops
Copy link
Contributor
@ekoops ekoops commented Apr 28, 2025 •
edited
Loading

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

This PR is part of a series #2343.
It removes the unused sinsp_event::clone_event() API.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

feat(userspace/libsinsp)!: remove unused `sinsp_evt::clone_event()`

@poiana poiana requested review from gnosek and hbrueckner April 28, 2025 15:30
@ekoops ekoops mentioned this pull request Apr 28, 2025
Open
25 tasks
@ekoops
feat(userspace/libsinsp)!: remove unused sinsp_evt::clone_event()
fd7a50c 
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
@ekoops ekoops force-pushed the ekoops/remove-unused-clone-event branch from 791cfd6 to fd7a50c Compare April 28, 2025 15:31
@ekoops ekoops changed the title feat(userspace/libsinsp)!: remove unused sinsp_evt::clone_event API feat(userspace/libsinsp)!: remove unused sinsp_evt::clone_event() Apr 28, 2025
@github-actions GitHub Actions
Copy link

Perf diff from master - unit tests

     5.96%     +0.67%  [.] sinsp::next
     6.69%     -0.65%  [.] sinsp_parser::reset
    35.38%     -0.45%  [.] sinsp_thread_manager::create_thread_dependencies
     5.16%     +0.27%  [.] sinsp_evt::get_type
     3.71%     -0.25%  [.] next_event_from_file
     1.79%     +0.25%  [.] sinsp_thread_manager::get_thread_ref
     0.56%     -0.24%  [.] sinsp_evt::get_direction
     2.53%     -0.22%  [.] gzfile_read
     1.40%     -0.20%  [.] next
     0.32%     +0.20%  [.] sinsp_parser::parse_context_switch

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0046         -0.0046           150           149           150           149
BM_sinsp_split_median                                          -0.0004         -0.0004           149           149           149           149
BM_sinsp_split_stddev                                          -0.5389         -0.5391             2             1             2             1
BM_sinsp_split_cv                                              -0.5368         -0.5370             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0321         +0.0321            59            61            59            61
BM_sinsp_concatenate_paths_relative_path_median                +0.0324         +0.0324            59            61            59            61
BM_sinsp_concatenate_paths_relative_path_stddev                -0.7969         -0.7969             1             0             1             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.8032         -0.8032             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0275         +0.0275            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_median                   +0.0324         +0.0324            24            24            24            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.5820         -0.5821             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.5932         -0.5932             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0003         -0.0003            63            63            63            63
BM_sinsp_concatenate_paths_absolute_path_median                +0.0118         +0.0119            62            62            62            62
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.6018         -0.6019             2             1             2             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.6017         -0.6018             0             0             0             0

@codecov Codecov
Copy link
codecov bot commented Apr 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.12%. Comparing base (ca91cb1) to head (fd7a50c).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2377      +/-   ##
==========================================
+ Coverage   77.02%   77.12%   +0.09%     
==========================================
  Files         229      229              
  Lines       30316    30278      -38     
  Branches     4657     4648       -9     
==========================================
  Hits        23352    23352              
+ Misses       6964     6926      -38
Flag Coverage Δ
libsinsp 77.12% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

FedeDP
FedeDP approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor
@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Apr 29, 2025
@poiana
Copy link
Contributor
poiana commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekoops, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor
poiana commented Apr 29, 2025

LGTM label has been added.

Git tree hash: 0c63378fd09d3e771cc07f0ebd5ddc16f6799f43

@FedeDP
Copy link
Contributor
FedeDP commented Apr 29, 2025

/milestone 0.21.0

@poiana poiana added this to the 0.21.0 milestone Apr 29, 2025
@github-project-automation github-project-automation bot moved this from Todo to In progress in Falco Roadmap Apr 29, 2025
@poiana poiana merged commit 52fef90 into falcosecurity:master Apr 29, 2025
47 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Falco Roadmap Apr 29, 2025
@ekoops ekoops deleted the ekoops/remove-unused-clone-event branch April 29, 2025 13:53
@bevanjkay bevanjkay mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogr leogr leogr approved these changes

@FedeDP FedeDP FedeDP approved these changes

@gnosek gnosek Awaiting requested review from gnosek

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

Assignees

@leogr leogr

@FedeDP FedeDP

Labels
approved area/libsinsp dco-signoff: yes kind/cleanup kind/feature New feature or request lgtm release-note size/M
Projects
Falco Roadmap
Status: Done
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ekoops @poiana @FedeDP @leogr
0